New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace `if (x) { addClass(y) } else { removeClass(y) }` with `toggleClass(y, x)` #1

Open

KyNorthstar opened this issue Apr 26, 2019 · 0 comments

Labels

Member

KyNorthstar commented Apr 26, 2019

These could be coalesced into one toggleClass

scripts/assets/v2/general/kt/src/org/bh/scripts/general/components/sidebar/SidebarController.kt

Lines 67 to 72 in 67e1680

    
           if (newIsShown) { 
        
               defaultElementResponsibleForHidingAndShowingTheSidebar.addClass(sidebarShownClassName) 
        
           } 
        
           else { 
        
               defaultElementResponsibleForHidingAndShowingTheSidebar.removeClass(sidebarShownClassName) 
        
           }

The text was updated successfully, but these errors were encountered:

KyNorthstar added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment