Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to drop MorphHelper.get #124

Open
asanin-epfl opened this issue Feb 10, 2021 · 1 comment
Open

Proposal to drop MorphHelper.get #124

asanin-epfl opened this issue Feb 10, 2021 · 1 comment

Comments

@asanin-epfl
Copy link
Contributor

asanin-epfl commented Feb 10, 2021

Bluepysnap should be an agnostic tool to read Sonata. Currently it forces user to load morphologies via NeuroM which is redundant and too specific. What if user wants MorphIO? Besides we can't do the same with neuron models because there are multiple possible formats. Each format requires its own library. Currently there are 5 formats => 5 additional dependencies just to read some formats. So, I decided not to introduce get in NeuronModelHelper, see PR#123

Here is the link to MorphHelper.get.

My proposal is to drop MorphHelper.get

cc @jdcourcol , @mgeplf , @tomdele

@jdcourcol
Copy link
Contributor

I think this is in close relationship to what @GianlucaFicarelli is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants