Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SunrisePlugin does not take DST into account #92

Closed
gabryelreyes opened this issue Nov 2, 2022 · 1 comment
Closed

SunrisePlugin does not take DST into account #92

gabryelreyes opened this issue Nov 2, 2022 · 1 comment
Labels
Duplicate This issue or pull request already exists.

Comments

@gabryelreyes
Copy link
Collaborator

  • Currently configured to Latitude 48.39 and Longitude 9.98
  • Plugin shows Sunrise at 5:05 and Sunset at 16:02.
  • Real sunrise and sunset offset one hour later than shown by the plugin.
  • Probably addCurrentTimezoneValues method does not take the DST into account.

How to reproduce:

  • Add SunrisePlugin to one of the slots in http://pixelix/display.html
  • Set Latitude and Logitude of current location in http://pixelix/plugins/SunrisePlugin.html
  • Compare times shown by the plugin with the time shown by a Google Search of "sunrise" or "sunset" accordingly
  • Times should have a difference of around one hour (as are calculated by different services)
@gabryelreyes gabryelreyes added the SW Bug Something isn't working in the software. label Nov 2, 2022
@BlueAndi
Copy link
Owner

BlueAndi commented Nov 2, 2022

see #29 - bugfix is available, but its still not merged to the Arduino lib as it looks like

@gabryelreyes gabryelreyes added Duplicate This issue or pull request already exists. and removed SW Bug Something isn't working in the software. labels Nov 2, 2022
@gabryelreyes gabryelreyes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists.
Projects
None yet
Development

No branches or pull requests

2 participants