Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy in CI? #306

Open
DimitriPapadopoulos opened this issue Nov 2, 2024 · 3 comments
Open

Run mypy in CI? #306

DimitriPapadopoulos opened this issue Nov 2, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@DimitriPapadopoulos
Copy link
Contributor

Add to .pre-commit-config.yaml to enforce that:

-   repo: https://github.com/pre-commit/mirrors-mypy
    rev: v1.13.0
    hooks:
     -  id: mypy
        files: "src"
@FrancescAlted
Copy link
Member

That would be worth a try.

@DimitriPapadopoulos
Copy link
Contributor Author

I would need help to fix all issues:

$ mypy src/blosc2
[...]
Found 170 errors in 8 files (checked 10 source files)
$ 

Static typing annotations are not useful without running a static type checker.

@FrancescAlted
Copy link
Member

Ok, this is a major task. Will have to be deferred probably after 3.0.0-rc1 which is coming soon.

@FrancescAlted FrancescAlted added the enhancement New feature or request label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants