Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled exceptions, cache unresolvable entities #163

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Fix unhandled exceptions, cache unresolvable entities #163

merged 6 commits into from
Sep 17, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

2 uncaught exceptions were identified in CertAbuseProcessor and LdapPropertyProcessor, this MR addresses them.

Additionally, unresolvable principals were not cached, and where repeatedly looked up which in certain cases could drastically impact performance.

Motivation and Context

https://specterops.atlassian.net/browse/BED-4822
https://specterops.atlassian.net/browse/BED-4836

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar requested a review from a team as a code owner September 16, 2024 21:39
@rvazarkar rvazarkar merged commit 0850cf4 into v4 Sep 17, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-4836 branch September 17, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@definitelynotagoblin definitelynotagoblin definitelynotagoblin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvazarkar @definitelynotagoblin