-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NTLMv1 flag on GPO #101
base: v3
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The implementation seems fine, but I'm sort of debating if it makes more sense to just merge this in with the existing gpo object processor stuff. @definitelynotagoblin @ddlees do either of you have any feelings on this? It is doing a bit more than our normal object processor does, but generally our processors are loosely linked to a particular collection method, so I think this would probably fit in ObjectProps instead |
Hi @Hackndo, Thank you for the two PRs - awesome work! 🙌 We have discussed internally and reached the conclusion that we would like to have two properties for this setting you collect:
The raw property should hold the int value of the registry setting. The other one should hold a string with corresponding setting value i.e. one of these:
Are you interested in updating your PR to create those properties? If not, then we will merge your PRs in and we will make the changes on top such that your commits still end up in the git history. Let me know what you think and thanks again for contributing! |
Hello, |
Hi @Hackndo, Just checking if you are still interested in making the update to the PR :) If not, we can still will merge your PRs in and make the changes on top such that your commits still end up in the git history. |
Hey there. I still have this in mind but yes, maybe it will be better if you merge and add the necessary changes on top. |
Similar to BloodHoundAD/SharpHound3#47
If GPO object forces LmCompatibilityLevel to be less than 3, then the computers it will be applied on will use NTLMv1 when authenticating.
This information seems very useful from an attacking perspective as authentication can be coerced and NTLMv1 hash cracked or relayed without MIC
(Also BloodHoundAD/SharpHound#87 on SharpHound)