Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused microblock variations #292

Open
oversword opened this issue Apr 2, 2021 · 3 comments · May be fixed by BlockySurvival/bls_custom#20
Open

Remove unused microblock variations #292

oversword opened this issue Apr 2, 2021 · 3 comments · May be fixed by BlockySurvival/bls_custom#20
Labels
actionable This issue has a PR or is otherwise ready to be actioned on the server general maintenance Doing this will make running the server easier in the long run. PR One of us needs to review/accept a PR in one of our repos. resolve in bls_custom used to be "swapshop needed" update request Request for an installed mod to be updated to a more current version

Comments

@oversword
Copy link
Member

Unused nodes to be removed:

artdeco:1c
artdeco:1d
artdeco:1f
artdeco:1g
artdeco:1i
artdeco:1j
artdeco:1k
artdeco:1l
artdeco:2b
artdeco:decoblock2
artdeco:decoblock4
artdeco:decoblock5
artdeco:tile5
moreblocks:clean_glow_glass
moreblocks:clean_super_glow_glass
moreblocks:desert_cobble_compressed
moreblocks:tar
my_door_wood:wood_brown
my_door_wood:wood_grey
scifi_nodes:blackoct
scifi_nodes:blackpipe
scifi_nodes:blackvnt
scifi_nodes:bluetile
scifi_nodes:doomengine
scifi_nodes:doomlight
scifi_nodes:doomwall2
scifi_nodes:doomwall4
scifi_nodes:doomwall41
scifi_nodes:doomwall42
scifi_nodes:doomwall43
scifi_nodes:doomwall431
scifi_nodes:doomwall44
scifi_nodes:fan
scifi_nodes:green2
scifi_nodes:greenbar
scifi_nodes:greenlights
scifi_nodes:greenlights2
scifi_nodes:greenmetal2
scifi_nodes:greybolts
scifi_nodes:greygreenbar
scifi_nodes:holes
scifi_nodes:octofloor
scifi_nodes:octofloor2
scifi_nodes:pplblk
scifi_nodes:ppllght
scifi_nodes:pplwll3
scifi_nodes:purple
scifi_nodes:red
scifi_nodes:red_square
scifi_nodes:rock2
scifi_nodes:rust
scifi_nodes:screen3
scifi_nodes:stripes2top
technic:blast_resistant_concrete
technic:cast_iron_block
technic:marble
technic:marble_bricks
techpack_stairway:lattice
terumet:block_coke
terumet:block_con_orange
terumet:block_con_pink
terumet:block_entropy

Also unused, but requested to be kept:

asteroid:redgravel
caverealms:mushroom_cap
cblocks:wood_magenta
cblocks:wood_violet
mahogany:leaves
This was referenced Apr 3, 2021
Open
Open
@oversword oversword added actionable This issue has a PR or is otherwise ready to be actioned on the server general maintenance Doing this will make running the server easier in the long run. PR One of us needs to review/accept a PR in one of our repos. resolve in bls_custom used to be "swapshop needed" update request Request for an installed mod to be updated to a more current version labels Apr 3, 2021
@fluxionary
Copy link
Member

out of curiosity, what'd you use to come up w/ the list of unused nodes? sometime soonish i may start working on a tool to help server admins identify variants that can be removed and remove them, but i don't really know a way to do that accurately w/out scanning the map database directly (not using the lua API).

@oversword
Copy link
Member Author

@fluxionary I was going to show you, but honestly it's horrific, and I can't remember or figure out exactly what it does...

Basically I made a python script to parse the postgres dump directly as a string, you'll want to look for "Data for Name: blocks;" for the start of the data, the most important part of the code is this:

i = line.index("\\x")+2
s = line[i:-1].upper()
b16 = base64.b16decode(s)
nodes = b16.decode("latin-1")

Where line is a line being parsed from postgres, and the output nodes is a string containing the names of the nodes stored in that line (there may be multiple).

You'll have to figure out the rest yourself, as my solution seems to involve a lot of weird stuff, and big data pasted in that presumably came from other pre-processes...

@fluxionary
Copy link
Member

alright, thanks for the reply, whenever i get around to doing this, i'll probably code up a python script that interacts w/ the database directly and generates lua code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable This issue has a PR or is otherwise ready to be actioned on the server general maintenance Doing this will make running the server easier in the long run. PR One of us needs to review/accept a PR in one of our repos. resolve in bls_custom used to be "swapshop needed" update request Request for an installed mod to be updated to a more current version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore the list of unused microblocks oversword/bls_custom
2 participants
@oversword @fluxionary