Optional serde #94
Merged
Optional serde #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include new fuzz targets. Add a shortcut to check if fuzz tests build.
witness("a") -> witness::A
The new witness expressions look like constants from the namespace
"witness". In the following commits, we will add this very namespace as
an optional part of a Simfony program. This will enable hardcoding
witness data inside the Program, for applications such as the web IDE.
Minimal code changes. Had to update all occurrences of witness
expressions inside example programs.
The set of tracked calls is fixed and never changes, so we can use Arc<[T]> instead of Vec<T>. The hash map of declared witnesses is still expensive to clone, though.
Introduce the `serde` feature which enables parsing of witness JSON files. In the future, witness data will also be able to be provided via Simfony code. In this case, we don't need serde. The web IDE will not need serde and will profit from a smaller WASM size by not including serde.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make witness JSON parsing via serde optional. Add a fuzz target for parsing const expressions as values. Update CI to run all fuzz targets in parallel.