Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-120] 🔀 Merge adding changelog into main #121

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ISSUE-120] 🔀 Merge adding changelog into main #121

wants to merge 5 commits into from

Conversation

MokhFn
Copy link
Contributor

@MokhFn MokhFn commented Aug 30, 2023 •
edited by LadyChristina
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing documentation?
  • Have you verified that there aren't any other open Pull Requests for the same update/change?
  • Does the Pull Request pass all tests?

Description

dimkarakostas
dimkarakostas requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@dimkarakostas dimkarakostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Remove the toc command and will merge afterwards.

CHANGELOG.md Outdated Show resolved Hide resolved
@MokhFn MokhFn changed the title [ISSUE-120] 🔀 Merge adding changelog into main [WIP][ISSUE-120] 🔀 Merge adding changelog into main Aug 31, 2023
@LadyChristina
Copy link
Member

Is this still work in progress?

@MokhFn
Copy link
Contributor Author

MokhFn commented Jun 4, 2024

@LadyChristina : Sorry, i have been busy, i'll re work on this ASAP and let you know.
Initially, i wanted to simply add a changelog. Then i thought it would be better to include tox, auto updates for docs and running tests withing a tox env, and update the CI structure a bit.
I can divide into two larger tasks/PRs, and this PRs becomes only a hangelog update/init.
Thoughts ?

@LadyChristina
Copy link
Member

Sounds good! Let's keep this PR just for the changelog and feel free to create a new branch for the other task

@MokhFn MokhFn changed the title [WIP][ISSUE-120] 🔀 Merge adding changelog into main [ISSUE-120] 🔀 Merge adding changelog into main Aug 25, 2024
@MokhFn
Copy link
Contributor Author

MokhFn commented Aug 25, 2024

Suggestion has been applied, but with all the history for the last year, what's the best way to go ?
Transcribe the 1-year history ? Or just keep the initial release, and wait until an automated releasing (and changelog update) is implemented to start transcribing history ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadyChristina LadyChristina Awaiting requested review from LadyChristina LadyChristina is a code owner

@dimkarakostas dimkarakostas Awaiting requested review from dimkarakostas dimkarakostas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add changelog/release history
3 participants
@MokhFn @LadyChristina @dimkarakostas