Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consensus/consensus.go #24

Closed
star-gazer111 opened this issue Aug 31, 2024 · 17 comments
Closed

Implement consensus/consensus.go #24

star-gazer111 opened this issue Aug 31, 2024 · 17 comments
Assignees

Comments

@star-gazer111
Copy link
Member

No description provided.

@DarkLord017
Copy link

assign please

@star-gazer111
Copy link
Member Author

@DarkLord017 what are the updates on the progress so far?

@DarkLord017
Copy link

Completed half of the functions rest are pending (structs are done)... I'll complete it by today EOD
sorry for late

@DarkLord017
Copy link

image
sir ye function helios me tha lekin networks.go me nhi hai
image

@DarkLord017
Copy link

DarkLord017 commented Sep 16, 2024

@star-gazer111
isko use he consensous me

@star-gazer111
Copy link
Member Author

@VeerChaurasia will create a new PR modifying networks.go by tomorrow. You can use it then.

@star-gazer111
Copy link
Member Author

@DarkLord017 refer #35

@DarkLord017
Copy link

Okay

@DarkLord017
Copy link

@star-gazer111 sir done hai almost consensus_core me utils file nhi thi uske functions consensus.go me likhu ya consensus core me utils.go ek file bnayi hai uski PR alag se kr du ?

@DarkLord017
Copy link

@star-gazer111 sir consensus.go me getpayload function define nahi hai lekin Helios me he aur uska use aa rha he to vo consensus me likhna he na ?
Aur sir tree hash root jo Helios me he vo library se le rhe hai to consensus.go me bhi koi library de dhundh ke import kar lu ?

@star-gazer111
Copy link
Member Author

@star-gazer111 sir done hai almost consensus_core me utils file nhi thi uske functions consensus.go me likhu ya consensus core me utils.go ek file bnayi hai uski PR alag se kr du ?

cool works

@star-gazer111
Copy link
Member Author

@star-gazer111 sir consensus.go me getpayload function define nahi hai lekin Helios me he aur uska use aa rha he to vo consensus me likhna he na ? Aur sir tree hash root jo Helios me he vo library se le rhe hai to consensus.go me bhi koi library de dhundh ke import kar lu ?

  • If any function was not defined initially but it's present in helios then u can define that yourself.
  • Yes, import tree hash root from one of the packages of geth .

@DarkLord017
Copy link

@star-gazer111 sir consensus.go me getpayload function define nahi hai lekin Helios me he aur uska use aa rha he to vo consensus me likhna he na ? Aur sir tree hash root jo Helios me he vo library se le rhe hai to consensus.go me bhi koi library de dhundh ke import kar lu ?

  • If any function was not defined initially but it's present in helios then u can define that yourself.
  • Yes, import tree hash root from one of the packages of geth .

Okay sir

@star-gazer111
Copy link
Member Author

@star-gazer111 sir consensus.go me getpayload function define nahi hai lekin Helios me he aur uska use aa rha he to vo consensus me likhna he na ? Aur sir tree hash root jo Helios me he vo library se le rhe hai to consensus.go me bhi koi library de dhundh ke import kar lu ?

  • If any function was not defined initially but it's present in helios then u can define that yourself.
  • Yes, import tree hash root from one of the packages of geth .

@DarkLord017 also, before defining anything in a new types.go please do check if we have already defined it somewhere in common or config module so we don't rewrite same thing again.

@DarkLord017
Copy link

okay sir

@VeerChaurasia
Copy link

@DarkLord017 do you need ChainID function and Baseconfig function(defined in networks.go) outside the package of config ?

@star-gazer111
Copy link
Member Author

Resolved here #51 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants