-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement consensus/types
#19
Comments
@ABD-AZE u can start working on this issue now. |
Assign please |
@star-gazer111 In the basic.go file, I don't think we require the ByteList struct as we can directly use [] byte. The transaction type can have the type [1073741824] bytes, with the ByteList type it would have dynamic size, which I think would not be efficient. |
@ABD-AZE what is the progress on this? |
I'll try to complete it in a day or two |
@star-gazer111, utsav had already written these types in his PR. Only a few functions need to be defined. So I don't think we have to write these types i two different places we can go ahead with what utsav has alreayd implemented. Just the folder structure needs to adjusted as he has defined those types in consensus_core package within the consensus package. Please tell me how should I proceed? |
ByteList is not needed to be reimplemented and same for common ones , jhst ensure the types are consistent. |
Resolved here #25 |
Implement all the files inside the
consensus/types
package.The text was updated successfully, but these errors were encountered: