Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consensus/types #19

Closed
star-gazer111 opened this issue Aug 25, 2024 · 9 comments
Closed

Implement consensus/types #19

star-gazer111 opened this issue Aug 25, 2024 · 9 comments
Assignees

Comments

@star-gazer111
Copy link
Member

Implement all the files inside the consensus/types package.

@star-gazer111
Copy link
Member Author

@ABD-AZE u can start working on this issue now.

@ABD-AZE
Copy link

ABD-AZE commented Aug 25, 2024

Assign please

@ABD-AZE
Copy link

ABD-AZE commented Aug 27, 2024

@star-gazer111 In the basic.go file, I don't think we require the ByteList struct as we can directly use [] byte. The transaction type can have the type [1073741824] bytes, with the ByteList type it would have dynamic size, which I think would not be efficient.

@star-gazer111
Copy link
Member Author

@ABD-AZE what is the progress on this?

@ABD-AZE
Copy link

ABD-AZE commented Aug 31, 2024

I'll try to complete it in a day or two

@star-gazer111
Copy link
Member Author

I'll try to complete it in a day or two

Incase, work on an issue takes longer than 4/5 days you can open up a PR & change it to a draft PR & keep working on it. You can later mark it as ready for review by following this

@ABD-AZE
Copy link

ABD-AZE commented Aug 31, 2024

@star-gazer111, utsav had already written these types in his PR. Only a few functions need to be defined. So I don't think we have to write these types i two different places we can go ahead with what utsav has alreayd implemented. Just the folder structure needs to adjusted as he has defined those types in consensus_core package within the consensus package. Please tell me how should I proceed?

@gerceboss
Copy link
Contributor

ByteList is not needed to be reimplemented and same for common ones , jhst ensure the types are consistent.

@star-gazer111
Copy link
Member Author

Resolved here #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants