-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement changePrizePool correctly #15
Comments
I would like to solve the issue |
sure, just make sure to follow the contributing guidlines. |
@lordshashank what should i do about it ?? |
try to increase optimizer runs to 2000 if it helps. |
It would not help in long go, comment out the getter functions for public vars as of now (as public vars have their own getter functions) and implement the team functionality. I guess we would have to shift to interfaces for different functionalities, would keep that for another patch. |
@lordshashank
|
The issue is already there #16 , this issue is independent of that, here our aim is to give an option to sponsor to change the prize distribution in main prize and pool prize, this should be pretty straight forward. |
@lordshashank, I would greatly appreciate your feedback on my pull request. It's my first contribution, and I'm eager to learn and improve. Please let me know if there are any areas that need attention or if you have any suggestions. Thank you! |
Resolved here #29 |
current implementation of
changePrizePool
is not optimal. It just increases the prize pool and that also without updating the prize structs.Re-implement the function as two functions
changePoolPrize
andchangePrizeArray
implementing prize changes for sponsors along with updating the relevant structs.The text was updated successfully, but these errors were encountered: