Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12: remove imp dependency #130

Open
vschmidt91 opened this issue Dec 16, 2024 · 3 comments
Open

Python 3.12: remove imp dependency #130

vschmidt91 opened this issue Dec 16, 2024 · 3 comments

Comments

@vschmidt91
Copy link

s2protocol uses the imp module which was removed in Python 3.12:
https://docs.python.org/3/library/imp.html

Any chance we can do without it?

@tchaecker
Copy link

tchaecker commented Dec 19, 2024

Hi vschmidt91, thanks raising this issue. That would require either raising that with Blizzard and hoping, Alternatively, we would need to create our own version of that protocol.

Is it realistic to not use the latest version of Python?

Edit: Are you interested in contributing? I want to build a team. The next task is to find more contributors or, preferable, partners and to map out what needs to be done.

@vschmidt91
Copy link
Author

Thanks for the assessment, I was just curious. This issue can probably be closed.

Background: burny-sc2 got updated to 3.12 recently and I'm using replay parsing for some ML predictors. But training can easily be decoupled from the bot itself, which seems like the way to go.

@Talv
Copy link

Talv commented Dec 20, 2024

There's PR with this already #126 (and it was there for quite a long time). However it's not going to be merged, or at least, it's hard to expect it, given that they (Blizzard) struggle with updating/maintaining the game, let alone developer tools like this one.

But it's a simple patch, you can just apply and be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants