-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache room users? #75
Comments
chucker
pushed a commit
to chucker/Gitter
that referenced
this issue
May 30, 2020
This also adds `GitterRoomUserOptions` in the vein of `GitterMessageOptions` so we can specify options like a query and a limit (defaulting to 30). It should be noted that this API seems to return unreliable (incomplete) results. See Blazored#75
I’ve started building this as a prototype, and it seems to work fine. The main sticking point right now is really finding a good control to add user autocomplete to the text box. |
SQL-MisterMagoo
pushed a commit
that referenced
this issue
Jun 3, 2020
This also adds `GitterRoomUserOptions` in the vein of `GitterMessageOptions` so we can specify options like a query and a limit (defaulting to 30). It should be noted that this API seems to return unreliable (incomplete) results. See #75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In testing the API, I've found that
/v1/rooms/:roomId/users
has the same weird query behavior as the regular gitter client — that is, some users simply cannot be found, for whatever reason. For example, queryingdanro
finds Dan Roth, but queryingsql
doesn't find anyone.So I don't think we should rely on that exclusively. (Is this considered a known bug on Gitter's end?)
But — we already get some of those users anyway, as part of
GetChatMessages
.So, what if we build a repository-esque class that builds a cache that fills as
GetChatMessages
andGetChatRoomUsers
queries come in, and returns a union of those? That should make querying users slightly more reliable.The text was updated successfully, but these errors were encountered: