Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish writing the Gitter API client #1

Open
SQL-MisterMagoo opened this issue Apr 19, 2019 · 6 comments
Open

Finish writing the Gitter API client #1

SQL-MisterMagoo opened this issue Apr 19, 2019 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SQL-MisterMagoo
Copy link
Collaborator

There are stubs for some of the main APis we might need, but many still need adding.
@SQL-MisterMagoo SQL-MisterMagoo added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 19, 2019
@SQL-MisterMagoo
Copy link
Collaborator Author

I don't think we need this as part of RC1 as it already has the parts we need for now.

@Liques
Copy link

Liques commented May 9, 2019

Could be great someday make the Gitter API as an external resource available to the community, maybe via nuget. :-)

@SQL-MisterMagoo
Copy link
Collaborator Author

Sure, that's definitely something I'd like to do.

@chucker
Copy link

chucker commented May 29, 2020

@SQL-MisterMagoo regarding @Liques's request, what would you say is the distinction between the Core and Library projects? The Library almost seems suitable to be considered a standalone API client library, but LocalisationHelper currently depends on IJSRuntime. Can we move LocalisationHelper to Blazor.Gitter.Core instead? Then Library should maybe become a package Blazored.Gitter.ApiClient.

chucker pushed a commit to chucker/Gitter that referenced this issue May 30, 2020
Implement GetChatRoomUsers. Helps with Blazored#1
42702fa 
This also adds `GitterRoomUserOptions` in the vein of `GitterMessageOptions` so we can specify options like a query and a limit (defaulting to 30).

It should be noted that this API seems to return unreliable (incomplete) results. See Blazored#75
@SQL-MisterMagoo
Copy link
Collaborator Author

@SQL-MisterMagoo regarding @Liques's request, what would you say is the distinction between the Core and Library projects? The Library almost seems suitable to be considered a standalone API client library, but LocalisationHelper currently depends on IJSRuntime. Can we move LocalisationHelper to Blazor.Gitter.Core instead? Then Library should maybe become a package Blazored.Gitter.ApiClient.

Sure - that makes sense - Library was intended to be the gitter library - probably localisation ended up there late one night and shouldn't have.

chucker pushed a commit to chucker/Gitter that referenced this issue Jun 1, 2020
Clarify intent of separate projects in README (see Blazored#1)
40c255d
@chucker
Copy link

chucker commented Jun 1, 2020

Sure - that makes sense - Library was intended to be the gitter library - probably localisation ended up there late one night and shouldn't have.

Right, thought so. That's #78 then.

SQL-MisterMagoo pushed a commit that referenced this issue Jun 3, 2020
@SQL-MisterMagoo
Implement GetChatRoomUsers. Helps with #1
5fc9f7f 
This also adds `GitterRoomUserOptions` in the vein of `GitterMessageOptions` so we can specify options like a query and a limit (defaulting to 30).

It should be noted that this API seems to return unreliable (incomplete) results. See #75
SQL-MisterMagoo pushed a commit that referenced this issue Jun 3, 2020
@SQL-MisterMagoo
Clarify intent of separate projects in README (see #1)
91aa578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chucker @Liques @SQL-MisterMagoo