Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerted reaction tests should also test against reaction free energy #89

Open
samblau opened this issue Mar 16, 2021 · 0 comments
Open
Assignees

Comments

@samblau
Copy link
Member

samblau commented Mar 16, 2021

Currently, concerted reaction addition tests only check the number of concerted reactions identified / added. However, we recently missed a bug which incorrectly modified the free energy of concerted reactions without changing the number of concerted reactions that are generated. A new test should be added or a current test should be extended to also check the properties of the generated concerted reactions in addition to the number of concerted reactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants