fix(Bulk Update): Only Validate Data for Current Item in Loop (#612)

* fix(Bulk Update): Only Validate Data for Current Item in Loop * Fix styling * Run pint * Fix styling --------- Co-authored-by: arthurkirkosa <[email protected]>
BinarCode · Aug 20, 2024 · 317b4e9 · 317b4e9
1 parent ab53475
commit 317b4e9
Show file tree

Hide file tree

Showing 26 changed files with 52 additions and 52 deletions.
diff --git a/src/Commands/PublishAuthCommand.php b/src/Commands/PublishAuthCommand.php
@@ -68,7 +68,7 @@ public function checkDirectory(string $path): self
 
     protected function copyDirectory(string $path, string $stubDirectory, string $format, ?array $actions = []): self
     {
-        $filesystem = new Filesystem();
+        $filesystem = new Filesystem;
 
         collect($filesystem->allFiles(__DIR__.$stubDirectory))
             ->filter(function (SplFileInfo $file) use ($actions) {

diff --git a/src/Fields/Concerns/Attachable.php b/src/Fields/Concerns/Attachable.php
@@ -89,7 +89,7 @@ public function authorizeToAttach(RestifyRequest $request)
             );
 
             if (! $this->authorizedToAttach($request, $pivot)) {
-                throw new AuthorizationException();
+                throw new AuthorizationException;
             }
         });
 
@@ -106,7 +106,7 @@ public function authorizeToSync(RestifyRequest $request)
             );
 
             if (! $this->authorizedToSync($request, $pivot)) {
-                throw new AuthorizationException();
+                throw new AuthorizationException;
             }
         });
 
@@ -123,7 +123,7 @@ public function authorizedToDetach(RestifyRequest $request, Pivot $pivot): bool
     public function authorizeToDetach(RestifyRequest $request, Pivot $pivot)
     {
         if (! $this->authorizedToDetach($request, $pivot)) {
-            throw new AuthorizationException();
+            throw new AuthorizationException;
         }
 
         return $this;
@@ -156,8 +156,8 @@ public function initializePivot(RestifyRequest $request, $relationship, $related
 
         if ($relationship->withTimestamps) {
             $pivot->forceFill([
-                $relationship->createdAt() => new DateTime(),
-                $relationship->updatedAt() => new DateTime(),
+                $relationship->createdAt() => new DateTime,
+                $relationship->updatedAt() => new DateTime,
             ]);
         }
 

diff --git a/src/Http/Controllers/Auth/ForgotPasswordController.php b/src/Http/Controllers/Auth/ForgotPasswordController.php
@@ -29,7 +29,7 @@ public function __invoke(Request $request)
             $request->input('url') ?? config('restify.auth.password_reset_url')
         );
 
-        (new AnonymousNotifiable())->route('mail', $user->email)->notify(new ForgotPasswordNotification($url));
+        (new AnonymousNotifiable)->route('mail', $user->email)->notify(new ForgotPasswordNotification($url));
 
         return ok(__('Reset password link sent to your email.'));
     }

diff --git a/src/Http/Controllers/RepositoryUpdateBulkController.php b/src/Http/Controllers/RepositoryUpdateBulkController.php
@@ -21,7 +21,7 @@ public function __invoke(RepositoryUpdateBulkRequest $request)
                     $repository = $request->repositoryWith($model);
 
                     return $repository
-                        ->allowToUpdateBulk($request)
+                        ->allowToUpdateBulk($request, $item)
                         ->updateBulk(
                             $request,
                             $id,

diff --git a/src/Http/Controllers/RestResponse.php b/src/Http/Controllers/RestResponse.php
@@ -252,8 +252,8 @@ public function __call($func, $args)
     public function respond($response = null): JsonResponse
     {
         if (! func_num_args()) {
-            $response = new \stdClass();
-            $response->data = new \stdClass();
+            $response = new \stdClass;
+            $response->data = new \stdClass;
 
             foreach (static::$RESPONSE_DEFAULT_ATTRIBUTES as $property) {
                 if (isset($this->{$property})) {
@@ -537,7 +537,7 @@ public function model(Model $model): self
 
     public static function created()
     {
-        return (new self())->code(201);
+        return (new self)->code(201);
     }
 
     public static function index(AbstractPaginator|Paginator $paginator, array $meta = []): JsonResponse

diff --git a/src/LaravelRestifyServiceProvider.php b/src/LaravelRestifyServiceProvider.php
@@ -62,7 +62,7 @@ public function packageRegistered(): void
 
         // Register the main class to use with the facade
         $this->app->singleton('laravel-restify', function () {
-            return new Restify();
+            return new Restify;
         });
     }
 

diff --git a/src/Repositories/ValidatingTrait.php b/src/Repositories/ValidatingTrait.php
@@ -171,7 +171,7 @@ public static function validatorForUpdateBulk(RestifyRequest $request, $resource
         })->toArray();
 
         return Validator::make(
-            $plainPayload ?? $request->all(),
+            [$plainPayload] ?? $request->all(),
             $on->getUpdatingBulkRules($request),
             $messages
         )->after(function ($validator) use ($request) {

diff --git a/src/Restify.php b/src/Restify.php
@@ -132,7 +132,7 @@ public static function repositories(array $repositories)
             (new BootRepository($repository))->boot();
         });
 
-        return new static();
+        return new static;
     }
 
     /**
@@ -149,7 +149,7 @@ public static function repositoriesFrom(string $directory, string $namespace): v
             return;
         }
 
-        foreach ((new Finder())->in($directory)->files() as $repository) {
+        foreach ((new Finder)->in($directory)->files() as $repository) {
             $repository = $namespace.str_replace(
                 ['/', '.php'],
                 ['\\', ''],

diff --git a/src/RestifyApplicationServiceProvider.php b/src/RestifyApplicationServiceProvider.php
@@ -133,7 +133,7 @@ protected function routes(): void
     protected function singleton(): void
     {
         if (! App::runningUnitTests()) {
-            $this->app->singletonIf(RelatedDto::class, fn ($app) => new RelatedDto());
+            $this->app->singletonIf(RelatedDto::class, fn ($app) => new RelatedDto);
         }
     }
 }
diff --git a/src/Services/Search/RepositorySearchService.php b/src/Services/Search/RepositorySearchService.php
@@ -219,6 +219,6 @@ protected function applyFilters(RestifyRequest $request, Repository $repository,
 
     public static function make(): static
     {
-        return new static();
+        return new static;
     }
 }
diff --git a/src/Traits/AuthorizableModels.php b/src/Traits/AuthorizableModels.php
@@ -145,15 +145,15 @@ public function authorizeToSync(Request $request, $method, Collection $keys): bo
     public function authorizeToDetach(Request $request, $method, $model)
     {
         if (! static::authorizable()) {
-            throw new AuthorizationException();
+            throw new AuthorizationException;
         }
 
         $authorized = method_exists(Gate::getPolicyFor($this->model()), $method)
             ? Gate::check($method, [$this->model(), $model])
             : false;
 
         if ($authorized === false) {
-            throw new AuthorizationException();
+            throw new AuthorizationException;
         }
     }
 
@@ -194,7 +194,7 @@ public function authorizedToDelete(Request $request): bool
     public function authorizeTo(Request $request, iterable|string $ability): void
     {
         if ($this->authorizedTo($request, $ability) === false) {
-            throw new AuthorizationException();
+            throw new AuthorizationException;
         }
     }
 
@@ -213,6 +213,6 @@ public function authorizedTo(Request $request, iterable|string $ability): bool
 
     public static function isRepositoryContext(): bool
     {
-        return new static() instanceof Repository;
+        return new static instanceof Repository;
     }
 }
diff --git a/src/Traits/AuthorizesRequests.php b/src/Traits/AuthorizesRequests.php
@@ -21,7 +21,7 @@ public static function auth($callback)
     {
         static::$authUsing = $callback;
 
-        return new static();
+        return new static;
     }
 
     /**

diff --git a/src/Traits/InteractWithSQLight.php b/src/Traits/InteractWithSQLight.php
@@ -19,7 +19,7 @@ public static function resolveConnection($connection = null)
 
     public static function bootSushi()
     {
-        $instance = (new static());
+        $instance = (new static);
         $cacheFileName = 'sushi-'.Str::kebab(str_replace('\\', '', static::class)).'.sqlite';
         $cacheDirectory = realpath(config('sushi.cache-path', storage_path('framework/cache')));
         $cachePath = $cacheDirectory.'/'.$cacheFileName;

diff --git a/src/Traits/InteractWithSearch.php b/src/Traits/InteractWithSearch.php
@@ -113,7 +113,7 @@ public static function collectFilters($type): Collection
 
             return $type instanceof Filter
                 ? tap($type, fn ($filter) => $filter->column = $filter->column ?? $column)
-                : tap(new $base(), function (Filter $filter) use ($column, $type) {
+                : tap(new $base, function (Filter $filter) use ($column, $type) {
                     $filter->type = $type ? $type : 'value';
                     $filter->column = $column;
                 });

diff --git a/tests/Actions/FieldActionTest.php b/tests/Actions/FieldActionTest.php
@@ -16,7 +16,7 @@ class FieldActionTest extends IntegrationTestCase
     #[Test]
     public function can_use_actionable_field(): void
     {
-        $action = new class() extends Action
+        $action = new class extends Action
         {
             public bool $showOnShow = true;
 
@@ -56,7 +56,7 @@ public function handle(RestifyRequest $request, Post $post)
     #[Test]
     public function can_use_actionable_field_on_bulk_store(): void
     {
-        $action = new class() extends Action
+        $action = new class extends Action
         {
             public bool $showOnShow = true;
 
@@ -101,7 +101,7 @@ public function handle(RestifyRequest $request, Post $post, int $row)
     #[Test]
     public function can_use_actionable_field_on_bulk_update(): void
     {
-        $action = new class() extends Action
+        $action = new class extends Action
         {
             public bool $showOnShow = true;
 

diff --git a/tests/Actions/PerformActionControllerTest.php b/tests/Actions/PerformActionControllerTest.php
@@ -64,7 +64,7 @@ public function test_could_perform_action_using_all(): void
         PostRepository::partialMock()
             ->shouldReceive('actions')
             ->andReturn([
-                new class() extends Action
+                new class extends Action
                 {
                     public static $uriKey = 'publish';
 

diff --git a/tests/Controllers/Index/IndexRelatedFeatureTest.php b/tests/Controllers/Index/IndexRelatedFeatureTest.php
@@ -34,7 +34,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->app->singletonIf(RelatedDto::class, fn ($app) => new RelatedDto());
+        $this->app->singletonIf(RelatedDto::class, fn ($app) => new RelatedDto);
     }
 
     public function test_can_retrieve_nested_relationships(): void
@@ -45,7 +45,7 @@ public function test_can_retrieve_nested_relationships(): void
                 'owner',
                 'users' => HasMany::make('users', UserRepository::class),
                 'extraData' => fn () => ['country' => 'Romania'],
-                'extraMeta' => new InvokableExtraMeta(),
+                'extraMeta' => new InvokableExtraMeta,
             ]);
 
         UserRepository::partialMock()

diff --git a/tests/Controllers/RepositoryAttachControllerTest.php b/tests/Controllers/RepositoryAttachControllerTest.php
@@ -186,7 +186,7 @@ public function test_many_to_many_field_can_intercept_attach_method(): void
 
                         return true;
                     })
-                    ->attachCallback(new AttachInvokable()),
+                    ->attachCallback(new AttachInvokable),
             ]);
 
         $this->postJson(CompanyRepository::route("$company->id/attach/users"), [

diff --git a/tests/Feature/ActionLogTest.php b/tests/Feature/ActionLogTest.php
@@ -105,7 +105,7 @@ public function test_can_create_log_for_repository_custom_action(): void
 
         $user = User::factory()->create();
 
-        $action = new class() extends Action
+        $action = new class extends Action
         {
             public static $uriKey = 'test action';
         };

diff --git a/tests/Feature/Filters/MatchFilterTest.php b/tests/Feature/Filters/MatchFilterTest.php
@@ -16,7 +16,7 @@ class MatchFilterTest extends IntegrationTestCase
 {
     public function test_matchable_filter_has_key(): void
     {
-        $filter = new class() extends MatchFilter
+        $filter = new class extends MatchFilter
         {
             public ?string $column = 'approved_at';
         };