-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapBox test report #538
Comments
What scree resolution you have. (Can be read from app under car info - advanced - hmi.display-*: xxx). |
Thank you for testing, and I'm pleased you are enjoying it! Automatic rerouting and turn-by-turn directions are hard, because I'm not actually sure how to locate the user along the route! I also worry that bugs in automatic rerouting may explode the number of route requests that are sent to the Mapbox service (Mapbox only gives 100,000 per month for free, which I will eventually need to spread among all of the app store users), and so the manual recalculation is a suitable compromise for this version. I believe Mapbox includes a small search history, but I count this as part of the saved places from #4. Rotating the map, similar to tilting the map, has complications because of the low update framerate over Bluetooth. I worry about the user experience of the map jumping around and showing a different arbitrary angle as it updates at 1fps. I don't have control over the information displayed on the map, unfortunately, that is provided by Mapbox. Thank you for your help in testing! |
@fata74 Thank you for testing! The map can only be displayed behind the other car UI elements (such as the status bar and the left navigation widgets). We might be able to expand it a little more to the left (@jezikk82 can you experiment and tell me the RHMIDimensions paddingLeft increase that is needed in your ID4 car?), but that is all that can be done. |
In #509 I asked how to build artefacts. RHMI dimensions are there. I can experiment with that. You can try to decrease left padding for id4 cars and see. |
I updated the dev docs to provide instructions which should help you test out RHMIDimensions changes, try it out! I don't have an ID4 car to test with, so I'll need to rely on your contributions. |
Hi hufman, my contribution with my experience so far and some minor improvements\bugfixes needed:
music stops, the display freezes on the map, I can change BMW screen to some other functionality but bluetooth connectivity remain "halted", I have close the unit navigation and wait that it completely turns off in order to make it work again. I've tried to get the logs but i do not why the logcat I take lately have only a few minutes of history. I'll try again in the next days.
|
Thank you for the testing and feedback, @berseker! |
.... you may be right, originally I had a 6,5" screen, then I bought an 8,8" screen from an F30 and codified it myself. but any other window of ID6 works properly. AFAIK the 1280x480 resolution are for 10.25" inches of other models like BMW X3\X5 and so on I just checked And I (should) have coded so I think something is wrong in my coding.. I will further investigate |
Oh good, that's at least an explanation! I know my 2021 Mini has an 8.8" screen that is technically 1440x540 but it claims to only be 1280x480, so I have a workaround just for Minis (perhaps because of their curved screens), and was worried I'd have to figure out more workarounds! The previous Mini ID4 XL screen was 8.8" and 1280x480. |
@fata74 @izzy-xd Please try this test build which changes the left padding and so the image should fill up the left side better. Please share a screenshot and the build number from the Support menu to help me with testing! @berseker Do you know the actual pixel resolution of the screen you installed? It seems that even IDrive 5 had the possibility of running at 1440x540, so I wonder if you might try coding your car to be a 8.8" 1440x540 resolution. What coding options do you see? |
@hufman i'll check about It.. actually the part Number of my 8.8" display Is 6822626, thats the only thing i know up until now |
I looked around for that part number and the forum posts all say 1280x480, I didn't find a definitive answer about whether it was potentially actually a higher res... Another test build removes the ID4 specific changes from the previous test build, because I think I added an extra change that may have corrected the padding problem without adding ID4-specific values, so I'd appreciate testing with that version too! |
I have tried this one: |
Hello @hufman, first at all, thank you very much for all your effort on this project, it is amazing what you have achieved. I know there is separate discussion on #517, but I wonder if it possible to get the same layout (size) @izzy-xd is showing now for Mapbox but for the screen mirroring app. I am using screen mirroring with Android Auto and I am still getting big black margins. Is there anything that can be adjusted to reduce the margins? My NBT resolution is 1280x480 Thank you very much! |
@izzy-xd did you uncheck the Widescreen Map setting? I haven't found any way to determine if the car is running in widescreen mode or sidebar mode, so this has to be done manually. I want to know if the sidebar mode lines up nicely with the edge of the screen when your car is showing a sidebar, or if it wastefully draws under the sidebar. I'm especially curious if the dimensions-testing version looks right in this regard (lined up perfectly in my Mini), because I like how the dimensions-testing version fills the screen more completely but worry that it would fill too much under the sidebar. @magamess As mentioned in the main discussion thread in #517, because AAIdrive is in control of its map, it can adjust the picture without the car's overlays drawing over any important parts of the map. The same negative padding could be applied for mirroring, but might cause image obstructions and so I don't feel comfortable applying it to the generic mirroring addon. But please, let's continue this discussion in the screen mirroring discussion section. |
Thank you for your testing and feedback! I've pushed up these changes to the main build. |
Hi Hufman. First of all, thanks as usual for all the hard work and the amazing results. Contextually, I tested Gmaps in screensharing via Android Auto app: results under bluetooth connection were acceptable and navigating inside the city was usable. Connected via USB was nearly perfect. I think I have read on a different issue that, under Android Auto, the screensharing of Gmaps has a better FPS. Isn't it the same or a similar rate of the Mapbox integration? |
I suppose rotating/tilting could be an option, especially for users who are using it over USB. The message you found about screen sharing is that the screen sharing app limits the update framerate while in motion to prevent watching movies in motion, while still updating the screen enough to show a map. It disables this limit if it is able to detect that Android Auto is running, and then it runs at the full speed supported by the USB or BT connection. |
hi @hufman , I'm still keeping updating the app & testing, I am actually amazed about the improvements! actually I still get many app crashes if I start listening mp3s with Musicolet as instance while using Mapbox.. it's something really istantaneus, as soon as i start listening music while mapbox is running the app gets an instant crash. this morning I was connected with both BT & USB, and I got this strange crash where music still played, mapbox was stuck, and also controls\album cover remained crashed (music still played, it switched to the next song but the controls & albumart remained on the previous song).. very strange. in any case also I would like to hightlight some glitches in the mapbox new features |
Please contribute your information about the map crashing to #536, it might be some memory pressure that suddenly ramps up as soon as you add the music app. |
I pushed a test build where any EntryEvo_ID5 car claiming to be 1280px wide will actually run as if it has a 1440x540 screen. Try that out @berseker |
@hufman "We have a Winner!" |
Ah ha, the image is too wide and the compass was cut off! I pushed a new version that should adjust the border padding to line up perfectly. @unlive74 can you post a picture of your EntryEvo_ID5 showing the map (preferably the main build, not the bmw_xl test build), and tell me what hmi.display-width the car reports? I'm trying to determine the rule for when to force the image to be bigger! |
@jezikk82 can you check the map size in your car (with pictures so I can measure and adjust if needed), I believe you also have a bigger screen size and I wonder if any of the screen measurements need adjusting. |
maybe a fine tuning it's necessary, but the compass actually appeared when I started moving with the car (if i remember correctly) in any case i'll try also this new pushed release ;) |
Sorry for late reply, this is how it looks (latest version, my own built) in my car AAID report resolution of 1440x540, NTBevo_ID5_1911_*, a4axl:false. NBT pro, biggest screen. According to BMW spec it should be 1920px wide screen, but according to my measure is about 1600px wide. |
Here is the variant with my adjustments I used with GMaps: Values are: val marginLeft: Int = 110 val paddingLeft: Int = 190 It's still require small corrections but I don't mind to have it as in pic. p.s. During "navi" I dont see any arrow showing directions or next turn - but I saw in commits history @hufman added it ? |
hmi.display-height: 480 |
Thank you so much! |
@hufman OK I'll try tomorrow. unfortunately for me it's just a test - the build with the map is irrelevant for me due to frequent crashes. At the same time, it also hangs the system (only rebooting EntryEvo helps). |
@hufman here is my test . I tried also mirroring plugin but I think you have made only the mod in the mapbox plugin for now |
Wonderful, thank you so much! You are correct, Screen Mirroring hasn't been changed yet, and I see from the code that it is using the Generic dimensions which move the screen up 80 pixels, while the dimensions specific to your screen would only move it up 60 pixels and should fix that. |
In any case please note that We are Talking about details to get to perfection, which Is really really close by now! |
@hufman Is there a way to overwrite object RHMIDimensions from class SidebarRHMIDimensions using the same way you posted in test build (in MapServiceApp.kt). This would allow the AAID to be built without compiling the IDriveConnectKit every time I play with something. Thanks. |
Of course! You can build whatever custom RHMIDimensions subclass you'd like, following this example, which doesn't require switching IDriveConnectKit from a gradle artifact to being a submodule. If you mean you want to tweak the SidebarRHMIDimensions, you can edit MapAppMode to return a custom subclass instead of the library's SidebarRHMIDimensions easy enough. |
I posted a debug branch and build that provides textboxes in the Settings tab to override the RHMIDimensions, which takes effect by closing and opening the map again instead of needing to recompile and reconnect to the car. @jezikk82 maybe that will help speed up your testing! |
Thanks, for sure it will help. I'll have access to 2 other bmws from f and g series with different i drives so I will try to adjust the mapbox as close as possible. Let me know if you prefer map on the left flot to border of the screen or end up before home button (delicate grey line in background noticeable). |
I somewhat like the appearance of the berseker screenshot, I think the Home button and floating Left button look a little out of place on the completely fullscreen picture and those 60 extra pixels won't contain much useful data. I sincerely appreciate your help! I think these screen dimensions are the last piece before I release the next stable version. |
Cool, thank you so much for the precise measurements! I updated the custom_dimensions build with the numbers, and I added a -20px offset for not-widescreen mode of that generation of screen. |
@jezikk82 did you find any needed updates for those other cars, or does everything look good? |
Closing this with the release of version 1.4, please open separate issues for any new bugs that appear! |
Hi, I just drive 60+ km with MapBox without issue. Everything worked fine, even the performance was better than GMaps.
I dont know if it's possible but would be nice to have:
The text was updated successfully, but these errors were encountered: