Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile along top of surprise plot #28

Open
btupper opened this issue Aug 24, 2023 · 6 comments
Open

profile along top of surprise plot #28

btupper opened this issue Aug 24, 2023 · 6 comments

Comments

@btupper
Copy link
Member

btupper commented Aug 24, 2023

Ahoy @chross22 and @jevanilla ! @SeascapeScience posed this question about adding a profile along the top of the heatmap... I have done in base R but never in grid graphics like ggplot. I can compute the profile, but how does one draw it? It might be that the generate the object ala p = ggplot() + ... then fish around in the object looking for the bounding box of the heatmap. Then what? Transform the profile to "heat map coordinates" and add as geom_line()?

I chatted with Andy P last night about our surprises paper. He had a pretty good idea..

On the surprise plot, add a line across the top that shows the proportion of boxes below it that are surprises. I’ve started sketching roughly what it would look like in the image below.

Screenshot 2023-08-24 at 10 34 43 AM
@btupper
Copy link
Member Author

btupper commented Aug 24, 2023

@jevanilla
Copy link
Collaborator

Seems like a good call. I'd like to see the line and bar versions.

@SeascapeScience
Copy link
Collaborator

Bars could look good!

@btupper
Copy link
Member Author

btupper commented Aug 24, 2023

The line looks like a sick worm. But the bars look OK - they get squished as the plot window area gets eaten up by the heatmap. Here's an example...

marginal

@SeascapeScience
Copy link
Collaborator

Thumbs up for the squished sick worm.

@btupper
Copy link
Member Author

btupper commented Aug 30, 2023

Take a look at the readme here I'm not convinced that the profile along the top is very compelling to the large story. Plus it chews up a lot of space.

I'm glad we have switched to surperimposed binary dots (surprise! no surprise). The matchup is much easier to identify, but it does raise issues (to my eye) that I discuss in the readme. It all does come down to the threshold (there's ALWAYS a threshold!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants