Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sending diagnostics command there is no 'completed sucessfully' published to the command status topic #208

Closed
metheos opened this issue Jun 5, 2024 · 1 comment · Fixed by #215
Assignees
Labels
bug Something isn't working

Comments

@metheos
Copy link

metheos commented Jun 5, 2024

In the case if (command === 'diagnostics' || command === 'enginerpm') { in file onstar2mqtt-bigthundersr-vehicle1/src/index.js there is no

                    client.publish(
                        commandStatusTopic,
                        JSON.stringify({
                            "command": {
                                "error": {
                                    "message": "Completed Successfully",
                                    "response": {
                                        "status": 0,
                                        "statusText": "Completed Successfully"
                                    }
                                }
                            },
                            "completionTimestamp": completionTimestamp
                        }), { retain: true }
                    );

like there is for other commands. This leaves the status topic stuck at 'sent'

@BigThunderSR BigThunderSR transferred this issue from BigThunderSR/homeassistant-addons-onstar2mqtt Jun 6, 2024
@BigThunderSR BigThunderSR added the bug Something isn't working label Jun 6, 2024
@BigThunderSR
Copy link
Owner

@metheos, thanks for catching this!

BigThunderSR added a commit that referenced this issue Jun 6, 2024
@BigThunderSR BigThunderSR linked a pull request Jun 6, 2024 that will close this issue
BigThunderSR added a commit that referenced this issue Jun 6, 2024
…s-command-there-is-no-completed-sucessfully-published-to-the-command-status-topic

Fix for #208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants