We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The stream error codes are modelled incorrectly.
Currently, wtransport just passes the error code numeric value (in fact, the same VarInt) through to the QUIC / HTTP3 layer.
wtransport
VarInt
However, this is not correct. WebTransport is supposed to apply the following conversion to the error codes:
fn webtransport_code_to_http_code(n: u32) -> wtransport::VarInt { let first: u64 = 0x52e4a40fa8db; let n: u64 = n.into(); let val: u64 = first + n + (n / 0x1e); val.try_into().unwrap() }
This is based on https://github.com/web-platform-tests/wpt/blob/master/webtransport/resources/webtransport-test-helpers.sub.js#L18 - which is based on https://ietf-wg-webtrans.github.io/draft-ietf-webtrans-http3/draft-ietf-webtrans-http3.html#section-4.3.
The text was updated successfully, but these errors were encountered:
Fix BiagioFesta#182: Convert error codes before passing them to QUIC
6707731
9cbcd80
BiagioFesta
Successfully merging a pull request may close this issue.
The stream error codes are modelled incorrectly.
Currently,
wtransport
just passes the error code numeric value (in fact, the sameVarInt
) through to the QUIC / HTTP3 layer.However, this is not correct. WebTransport is supposed to apply the following conversion to the error codes:
This is based on https://github.com/web-platform-tests/wpt/blob/master/webtransport/resources/webtransport-test-helpers.sub.js#L18 - which is based on https://ietf-wg-webtrans.github.io/draft-ietf-webtrans-http3/draft-ietf-webtrans-http3.html#section-4.3.
The text was updated successfully, but these errors were encountered: