Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy version due to incompatibility with numba #219

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

lazigu
Copy link
Collaborator

@lazigu lazigu commented Mar 21, 2023

See #215
The issue will be renamed, but not closed to not forget to remove the pinned version when the problem is fixed.

Copy link
Member

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #219 (f13121c) into main (4d3e293) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files          14       14           
  Lines        1346     1346           
=======================================
  Hits         1040     1040           
  Misses        306      306           
Impacted Files Coverage Δ
napari_clusters_plotter/_plotter.py 50.61% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lazigu lazigu merged commit bb9e370 into main Mar 21, 2023
@lazigu lazigu deleted the pin-numpy-version branch March 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pinned numpy version when the problem is fixed (UMAP not working with Numpy>1.23.5)
2 participants