From 46b61744b999ed60c1fcbea51d1e4353b2fa062c Mon Sep 17 00:00:00 2001
From: Dan Bonachea <dobonachea@lbl.gov>
Date: Fri, 4 Oct 2024 20:48:35 -0700
Subject: [PATCH] Repair the non-functional false-assertion test

This test has apparently been returning nonsense since the
false-assertion example was renamed in 6f4ddfd.

The test design (nested invocation of fpm) remains horribly fragile
for multiple fundamental reasons, but at least it's once again working
as intended (at least on gfortran).
---
 test/run-false-assertion.sh                   |  2 +-
 ...st-assert-subroutine-error-termination.F90 | 19 +++++++++++--------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/test/run-false-assertion.sh b/test/run-false-assertion.sh
index 22878f1..cd2f664 100755
--- a/test/run-false-assertion.sh
+++ b/test/run-false-assertion.sh
@@ -1,3 +1,3 @@
 #!/bin/bash
-output=$(fpm run --example false_assertion --compiler flang-new --flag '-mmlir -allow-assumed-rank -O3' > /dev/null 2>&1)
+output=$(fpm run --example false-assertion --compiler flang-new --flag '-mmlir -allow-assumed-rank -O3 -DASSERTIONS' > /dev/null 2>&1)
 echo $?
diff --git a/test/test-assert-subroutine-error-termination.F90 b/test/test-assert-subroutine-error-termination.F90
index 14dd808..4fb8ef1 100644
--- a/test/test-assert-subroutine-error-termination.F90
+++ b/test/test-assert-subroutine-error-termination.F90
@@ -5,22 +5,25 @@ program test_assert_subroutine_error_termination
   
   integer exit_status
 
-  ! TODO: add '--profile release' if used in the 'fpm test' invocation that causes the program
-  ! ../example/test-assert-subroutine-error-termination.F90 to excute this example program.
-
   print *
   print *,"The assert subroutine"
+
+  ! TODO: The following is a HORRIBLY fragile test. 
+  ! Specifically, it encodes a bunch of compiler-specific flags into an fpm command, 
+  ! and if fpm fails for any unrelated reason (broken command, compile error, I/O error, etc)
+  ! we will mistakenly interpret that as a passing test!
+
   call execute_command_line( &
 #ifdef __GFORTRAN__
-    command = "fpm run --example false_assertion > /dev/null 2>&1", &
+    command = "fpm run --example false-assertion --profile release --flag '-DASSERTIONS -ffree-line-length-0' > /dev/null 2>&1", &
 #elif NAGFOR
-    command = "fpm run --example false_assertion --compiler nagfor --flag -fpp > /dev/null 2>&1", &
+    command = "fpm run --example false-assertion --compiler nagfor --flag '-DASSERTIONS -fpp' > /dev/null 2>&1", &
 #elif __flang__
     command = "./test/run-false-assertion.sh | fpm run --example check-exit-status", &
 #elif __INTEL_COMPILER
-    command = "fpm run --example false_assertion --compiler ifx --flag -O3 > /dev/null 2>&1", &
-#elif __CRAYFTN
-    command = "fpm run --example false_assertion --compiler crayftn.sh > /dev/null 2>&1", &
+    command = "fpm run --example false-assertion --compiler ifx --flag '-DASSERTIONS -O3' > /dev/null 2>&1", &
+#elif _CRAYFTN
+    command = "fpm run --example false-assertion --profile release --compiler crayftn.sh --flag '-DASSERTIONS' > /dev/null 2>&1", &
 #else
     command = "echo 'example/false_assertion.F90: unsupported compiler' && exit 1", &
 #endif