(not a bug) Just nitpicking on some things i've noticed

[mrfloris]

Hey there,

I am too unfamiliar with this github stuff, so this will hopefully do. This is about a few things I've noticed.

• The main github page https://github.com/BentoBoxWorld/BentoBox doesn't mention greenhouse add-on. I found it on Jenkins.

• The github page https://github.com/BentoBoxWorld/Greenhouses doesn't have a link on the readme to Jenkins build https://ci.codemc.org/job/BentoBoxWorld/job/Greenhouses/.

• The add-on is called greenhouses (plural) but the command does not work inside the game. The in-game command is /is greenhouse

• The github and jenkins are all plural, I personally understand that, but keep typing greenhouse, since you're working with 'one'. So I guess that's fine. Maybe at least add an alias so they both work? /is greenhouse + /is greenhouses
  Because first installation, I thought I mistyped the command, or didn't install it properly. Typed gre... and it auto suggested with greenhouse (not plural). (Again, personally i really prefer just greenhouse, hehe)

• The github readme page for greenhouses mentions the same things twice:

admin commands:
greenhouses reload : Reloads config files
greenhouses info : provides info on the player's island greenhouses
greenhouses info: provides info on the greenhouse you are in

• Talking about commands, as operator on the server I don't get most of the listed commands actually. I can use:

/is greenhouse (opens the gui menu) (which is not listed in help)
/is greenhouse help (lists the help) (which is not listed in help)
/is greenhouse make (force-make a greenhouse, or maybe first one it finds)
/is greenhouse remove (removes the one you stand in)

The readme lists however (and implies these are listed in greenhouse help):

/is greenhouses help - lists these commands
/is greenhouses make: Tries to make a greenhouse by finding the first valid recipe
/is greenhouses remove: Removes a greenhouse that you are standing in if you are the owner
/is greenhouses list: Lists all the recipes available
/is greenhouses recipe: Display the recipe GUI - clicking on a recipe will try to make a /is greenhouse

Both greenhouse recipe and greenhouse list don't seem to exist.

• When using the nether recipe/biome, the whole text goes red, it doesn't seem to 'reset' if that makes sense. see img

• Fun fact, the thing from earlier about something being listed twice, the greenhouse info, isn't listed as a command, nor works in-game. Same for greenhouse reload.
  (any none working sub-command just shows the help page btw)

• Using bonemeal in hoppers, the 'tall' flowers don't show, their bottom half does, not their top half

FEATURE REQUESTS

While I am here ;P

Could it be possible to limit greenhouse only to our world named /skyblock/ or our /acid/ map ? .. and not have it work in say our wild world or a towny map ?

And would it be possible to limit the player to one greenhouse at a time? Instead of allowing them to i believe make as many as they want? We run in difficulty hard for skyblock/ and would not mind if they have to work for some items.

[mrfloris]

Uhm, we noticed that horses spawn perfectly fine, but a bit too much. From what I understand the max should be one ?

  PLAINS:
    friendlyname: "Horse Plains"
    biome: PLAINS
    icon: GRASS_BLOCK
    priority: 1
    contents:
      GRASS_BLOCK: 3
    plants:
      TALL_GRASS: 10:GRASS_BLOCK
    mobs:
      HORSE: 10:GRASS_BLOCK
    moblimit: 1

we have 12 horses and growing, ..

Do i misunderstand mob limit ?

[tastybento]

I'll answer the last question first and then post other answers. Mob limit is how many blocks of area each mob must have. So you have it set to 1 so that means a horse only needs 1 block. Set it to 9 or something.

[tastybento]

The background on the bad docs is because this add-on is a port from the Greenhouses plugin that I wrote and I copied over the text from there. Unfortunately, I'm always busy doing other things so I haven't been able to implement those other features yet. I did Greenhouses as a real minimum-viable-release just to get it out there for BentoBox and so that explains the lack of love. I need to clean stuff up!

Could it be possible to limit greenhouse only to our world named /skyblock/ or our /acid/ map ? .. and not have it work in say our wild world or a towny map ?

Yes. That's a bug actually. It should only work in island worlds.

Using bonemeal in hoppers, the 'tall' flowers don't show, their bottom half does, not their top half

I think there was another issue on this filed. I need to try and work out how to do this.