-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datumizes storage from a component #11894
base: master
Are you sure you want to change the base?
Conversation
dreamseeker_wZ3bHmvYs8.mp4yea. Time to learn how actions work |
it seems action holder PR might be good to go with |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR has been marked as stale due to being in an unmergable state for 7 days. Please resolve any conflicts and add testing evidence, then contact a project maintainer to have the stale label removed. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
closes #12132
This PR moves storage from being a component to being a datum.
We kill
/datum/component
and its handlerGetComponent()
, and replace it withatom_storage
andproc/create_storage(. . .)
Entirely removes signal overhead.
Included are some minor additional QOL/fixes for storage. (and some very not-minor fixes from the original tg pr)
Ports:
silent_for_user
var to mute storage messages only for the user. tgstation/tgstation#70941Why It's Good For The Game
We are making literal hundreds (maybe thousand) of GetComponent calls during initialize whenever we want to handle or modify the storage component. This is for every item.
This and the signal use contribute some not-so-insignificant overhead.
This makes that not happen. Yay.
The cool thing about atom storage is that, like the atomized integrity pr, you can now put it on nearly anything.
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_qjKiEPJuP5.mp4
Changelog
🆑 rkz, magatsuchi, JohnFulpWillard, GuillaumePrata, Vishenka0704
refactor: refactored storage component to be datumized
tweak: tweaked overall weight of items so all the outfits fit again. TELL ME IF IT IS A SIGNIFICANT DEPARTURE FROM BEFORE, it should be about the same. Most of them were relating to ERT.
balance: increased the slots of ERT/Abductor bags because trying to fit all those items that featurecoders like to put in them was causing errors during outfit init.
tweak: decreased storage notification spam for ore bags
add: adds storage mass transferring to griddles
/:cl: