Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same Lightbox gallery (with inter-linked images) in the profile's main page than on the gallery page #289

Open
nekohayo opened this issue May 20, 2022 · 2 comments
Labels
recode This label is used when an issue is related to a re-coding task.

Comments

@nekohayo
Copy link

If you go to https://www.bewelcome.org/members/$your_username, at the bottom there is "Latest pictures". However, they are super tiny (please make them bigger instead of having so much padding around the thumbnails!) and when you click on any of them, you are taken to the individual image's page instead of simply zooming into the image with Lightbox and being able to flip through all the images with the Left/Right arrow keys (or the floating arrows you would get in Lightbox if you tell it to show a collection of images). It's slow and cumbersome (you then have to use the browser's back button to see another image, then click again, etc etc.)

I know you already have the Lightbox code for this because that's exactly how it works in https://www.bewelcome.org/gallery/show/user/$your_username/images, so it's a matter of reusing that code directly on the profile page and considering the photos as a linked gallery set (instead of individual images), bringing that UX improvement directly to the profile page, instead of using it only in one hidden place.

@thisismeonmounteverest thisismeonmounteverest added the recode This label is used when an issue is related to a re-coding task. label May 21, 2022
@thisismeonmounteverest
Copy link
Contributor

This will be implemented when the profile pages code gets rewritten.

zeuros pushed a commit to zeuros/rox that referenced this issue Oct 25, 2022
…images) in the profile's main page than on the gallery page
@zeuros
Copy link
Contributor

zeuros commented Oct 25, 2022

Did a PR for that, tell me if you can give it a go

thisismeonmounteverest pushed a commit that referenced this issue Oct 28, 2022
…n the profile's main page than on the gallery page (#307)

Co-authored-by: zeuros <tetzzg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recode This label is used when an issue is related to a re-coding task.
Projects
None yet
Development

No branches or pull requests

3 participants