We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In each helper, we duplicate code and reuse the same "helper" to get possible ACF media fields to work with.
So we could move and refactor recursive_get_post_media_fields into admin/main to be triggered on acf_save_post action.
recursive_get_post_media_fields
admin/main
acf_save_post
This will cause to check fields once and save somewhere as static to faster/easier reuse into helpers.
@herewithme your thought ?
The text was updated successfully, but these errors were encountered:
@MaximeCulea 100% agree. But I'm not sure that we should invest time on the current format because ACF should be totally outsourced in an addon.
Sorry, something went wrong.
Let's do things step by step ;) We should have done it here #51 (comment) :p Anyway I created an issue #68 to focus on this refactoring.
Yes, complementary subject.
herewithme
MaximeCulea
No branches or pull requests
In each helper, we duplicate code and reuse the same "helper" to get possible ACF media fields to work with.
So we could move and refactor
recursive_get_post_media_fields
intoadmin/main
to be triggered onacf_save_post
action.This will cause to check fields once and save somewhere as static to faster/easier reuse into helpers.
@herewithme your thought ?
The text was updated successfully, but these errors were encountered: