Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Icon for https #24

Open
jdittrich opened this issue Jun 15, 2013 · 3 comments
Open

Change Icon for https #24

jdittrich opened this issue Jun 15, 2013 · 3 comments
Assignees

Comments

@jdittrich
Copy link
Member

It is great that users are easily informed by icons about the type of media they are going to get if they click on a link. However, the "Lock" for https is confusing.


bildschirmfoto vom 2013-06-15 21 35 09


What happens now:
http:// links are marked by a arrow-icon, while https:// links are signified by a lock-symbol. This is potentially confusing: The lock might be mistaken for restricted access for the user (log in needed) and while the result of a http and a https link has for the user the same result, they look totally different.

What should happen:
Https links should use the same symbol as http links, as their result is the same. If somebody knows about https/http, we can savely assume that this person is able to look at the url itself.

@ghost ghost assigned audiocommander Jun 25, 2013
@jdittrich
Copy link
Member Author

fixed in css.

@audiocommander
Copy link
Member

Not sure if it's a good idea to edit files in skins/vector/ because all these changes will be overwritten automatically once the wiki installation will be updated. This is especially complicated for me, because I don't really know which files you edited, so there's a really big chance that I will erase most of what you did eventually.

It would be much safer if you created an additional css file, where you override and/or add styles. Most modern editors allow for runtime CSS injections, so you should be able to create this additional CSS even without a working BUW.skin

@jdittrich
Copy link
Member Author

Currently I did almost all of the changes in the screen css in a separate section at the end of the vector file screen.css. So one could copypaste the changes and additions in an extra file which could be loaded after the other CSS files, thus overwriting the existing styles.

My latest information was that I work on /vector until we got a working BUW skin (which is essentially a copy of vector). You have more experience in administrating media wiki (and dealing with special wishes regarding the wiki) so I would take your suggestion of what we should do instead (I would need some advice there cause I don't know what a editor runtime CSS injection is/is going to do) We probably should take decisions and discussion to #26 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants