Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Store input file data labels in pybamm.Experiment format #64

Open
3 tasks
sjrowlinson opened this issue Mar 24, 2023 · 2 comments
Open
3 tasks

Store input file data labels in pybamm.Experiment format #64

sjrowlinson opened this issue Mar 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sjrowlinson
Copy link
Contributor

Process the data labels from the input files, and convert them into the statement syntax used to construct pybamm.Experiment objects.

  • Biologic
  • Ivium
  • Maccor
@sjrowlinson sjrowlinson added the enhancement New feature or request label Mar 24, 2023
@mjaquiery
Copy link
Collaborator

This seems like a good addition; I know the AmpLabs people were interested in PyBAMM as a central format. I'm not quite clear on what we want witht this issue or where it fits in, though.

  • Should we be storing file metadata in pybamm.Experiment format (or a serialized instance of it) in our own back end?
  • Are we exposing a mechanism for users to export our data in pybamm.Experiment format?
  • Is this something that should be done to all files at parse time, or is it something we want to ensure we can do for files we've stored?
  • How might we implement this in the web frontend?

@mjaquiery
Copy link
Collaborator

Need to pick this back up on the feature/pybamm_labels branch when ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants