Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregated modifications from multiple prior PRs #121

Merged
merged 91 commits into from
Sep 9, 2024
Merged

aggregated modifications from multiple prior PRs #121

merged 91 commits into from
Sep 9, 2024

Conversation

rfl-urbaniak
Copy link
Contributor

@rfl-urbaniak rfl-urbaniak commented Mar 12, 2024 •
edited
Loading

This includes multiple PRs that were previously approved, deployed and tested. A few minor changes w.r.t. the most recent deployed version are:

  • test and lint have been decoupled in the workflow
  • notebook tests are part of the test workflow to avoid redundant checkouts and installs and resolve execution dependencies
  • pyro is now fixed to be at 1.8.5
  • for now suspended isort as in CI it fails to work properly with --profile black despite isort version agreement between the local install and the runner
  • test_inference has been slightly simplified.

All the above changes are coming up with the migration to sql anyway, so the relevant files have been checked out from ru-sql to minimize conflicts later.

Niklewa and others added 30 commits January 10, 2024 12:54
@Niklewa
adding communities dataset
dbf0291
@Niklewa
adding communities variables WIP
20d3b5f
@Niklewa
adding age composition WIP
1edf76a
@Niklewa
lint
2d34569
@Niklewa
pulling from ru-percentile
f27ab85
@Niklewa
linting
ee36c64
@Niklewa
adding processed vars communities
0d76ed2
@Niklewa
refactoring paths in cleaning files
d3edb95
@Niklewa
linting
9b05b6f
@Niklewa
running cleaning pipeline
56e29b1
@Niklewa
adding data documentation
4f29edc
@Niklewa
Merge branch 'ru-training-pipeline' of https://github.com/BasisResear…
82493b3 
…ch/cities into nl-add-climate-and-economic-justice
@rfl-urbaniak
Merge branch 'main' of https://github.com/BasisResearch/cities into n…
7345e92 
…l-add-climate-and-economic-justice
@rfl-urbaniak
rtrol in test_sorted... froom .01 to .02
33bd925
@rfl-urbaniak
Merge pull request #102 from BasisResearch/nl-add-climate-and-economi…
ab072c9 
…c-justice

Adding climate and economic justice variables, and age composition (counties)
@rfl-urbaniak
skipping inference tests for now
f7e393b
@rfl-urbaniak
suspending inference tests
234a68b
@rfl-urbaniak
Merge branch 'ru-vectorize-predictions' of https://github.com/BasisRe…
38bb662 
…search/cities into staging-county-data
@rfl-urbaniak
temporarily moving caual notebooks out of testing until models are re…
c5db754 
…trained
@Niklewa
seperating burdens
75161bc
@Niklewa
seperating hazard variable
8bcabe0
@Niklewa
lint
c63b1a3
@Niklewa
adding raw homeownership variables
abfcf73
@Niklewa
added processed variables and documentation
e416587
@Niklewa
formatting exclusions
b2a2a6c
@Niklewa
running clean_gdp
90d31d3
@Niklewa
taking age raw from 2021
2151f32
@Niklewa
running cleaning pipeline
48fdac2
@Niklewa
adding raw income_distribution
7be779c
@Niklewa
adding processed income_distribution
fc4d609
Niklewa and others added 22 commits January 17, 2024 20:37
@Niklewa
editing conceptual overview
cdefed4
@rfl-urbaniak
Merge pull request #112 from BasisResearch/nl-modify-data-sources
19e66fd 
Adding info. on burdens and hazards variables
@rfl-urbaniak
some revisions
b6e875b
@rfl-urbaniak
Merge pull request #111 from BasisResearch/nl-add-api-guide
78621e2 
Adding conceptual overview notebook
@rfl-urbaniak
Merge branch 'staging-county-data' of https://github.com/BasisResearc…
decce08 
…h/cities into ru-describe-inference
@rfl-urbaniak
counterfactual explanation WIP
2d3fda8
@rfl-urbaniak
counterfactual-explained first pass
4a79708
@rfl-urbaniak
Merge pull request #113 from BasisResearch/ru-describe-inference
4274e37 
add `counterfactual_explained.ipynb`
significance -> importance to desc weights; etc
8abaf83
minor clarifications to docs
9953024
@rfl-urbaniak
added covariate correlations and elimination to data prep
aee3dc2
@rfl-urbaniak
still skipping inference tests
de787fd
@rfl-urbaniak
models retrained
e7ae05f
@rfl-urbaniak
added tau samples and years
197af41
@rfl-urbaniak
tests passed
31cb222
@rfl-urbaniak
notebook tests passed
0e02645
@riadas
Merge pull request #119 from BasisResearch/ru-retrain-models
0cfefe2 
retrain models, reinstate all tests and notebook tests
@rfl-urbaniak
ignore Adam linting error
5c84ddd
@rfl-urbaniak
isort
e77e779
@rfl-urbaniak
updated tests and linting in ligth of upcoming changes from ru-sql
dcc9df9
@rfl-urbaniak
update to tests and lints in light of upcoming ru-sql
2acf01a
@rfl-urbaniak
removed db tests from workflow
84d39b4
@rfl-urbaniak rfl-urbaniak requested a review from riadas March 13, 2024 10:11
@rfl-urbaniak rfl-urbaniak requested review from Niklewa and removed request for riadas August 20, 2024 13:56
@rfl-urbaniak rfl-urbaniak merged commit db66c26 into main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niklewa Niklewa Niklewa approved these changes

Assignees
No one assigned
Labels
status: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfl-urbaniak @Niklewa @riadas