Skip to content

Commit

Permalink
todo about mypy in simple_linear
Browse files Browse the repository at this point in the history
  • Loading branch information
rfl-urbaniak committed Jun 21, 2024
1 parent a5ed053 commit e68d51e
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion cities/modeling/simple_linear.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def forward(
].squeeze(-1)

objects_cat_weighted[name] = weights_categorical_outcome[name][
..., categorical[name]
..., categorical[name]
]

# most likely too add hoc and now redundant
Expand Down Expand Up @@ -242,3 +242,20 @@ def unconditioned_model():

def forward(self):
return self.conditioned_model()



#TODO mypy linting

# + mypy --ignore-missing-imports cities/
# cities/modeling/simple_linear.py:26: error: Name "pyro.nn.PyroModule" is not defined [name-defined]
# cities/modeling/simple_linear.py:72: error: Module has no attribute "sample" [attr-defined]
# cities/modeling/simple_linear.py:74: error: Module has no attribute "plate" [attr-defined]
# cities/modeling/simple_linear.py:97: error: Module has no attribute "plate" [attr-defined]
# cities/modeling/simple_linear.py:102: error: Module has no attribute "sample" [attr-defined]
# cities/modeling/simple_linear.py:143: error: Module has no attribute "plate" [attr-defined]
# cities/modeling/simple_linear.py:144: error: Module has no attribute "sample" [attr-defined]
# cities/modeling/simple_linear.py:154: error: Module has no attribute "sample" [attr-defined]
# cities/modeling/simple_linear.py:176: error: Module has no attribute "deterministic" [attr-defined]
# cities/modeling/simple_linear.py:182: error: Module has no attribute "sample" [attr-defined]
# cities/modeling/simple_linear.py:191: error: Name "pyro.nn.PyroModule" is not defined [name-defined]

0 comments on commit e68d51e

Please sign in to comment.