Andy's comments

BasisResearch · Jun 27, 2024 · 411989c · 411989c
1 parent e3a2e89
commit 411989c
Show file tree

Hide file tree

Showing 5 changed files with 216 additions and 241 deletions.
diff --git a/cities/modeling/simple_linear.py b/cities/modeling/simple_linear.py
@@ -99,6 +99,7 @@ def forward(
             objects_cat_weighted = {}
 
             for name in categorical_names:
+                #TODO consider expanded sampling instead of plate
                 with pyro.plate(
                     f"w_plate_{name}",
                     size=len(categorical_levels[name]),

diff --git a/docs/experimental_notebooks/zoning/zoning_categorical_interactions.ipynb b/docs/experimental_notebooks/zoning/zoning_categorical_interactions.ipynb
diff --git a/docs/experimental_notebooks/zoning/zoning_data.ipynb b/docs/experimental_notebooks/zoning/zoning_data.ipynb
diff --git a/docs/experimental_notebooks/zoning/zoning_model.ipynb b/docs/experimental_notebooks/zoning/zoning_model.ipynb
diff --git a/docs/experimental_notebooks/zoning/zoning_performance_tests.ipynb b/docs/experimental_notebooks/zoning/zoning_performance_tests.ipynb