Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial value of FilterQuality in cached_network_image is different from Flutter(since ver 3.24.0)'s default value. #991

Open
kouroku-room opened this issue Nov 23, 2024 · 0 comments

Comments

@kouroku-room
Copy link

🐛 Bug Report

In the CachedNetworkImage() method, the initial value of FilterQuality is FilterQuality.low, but in the Image() method of the Flutter SDK from Flutter 3.24.0, the initial value of filterQuality is FilterQuality.medium.

Details: Flutter Official Release Notes -> 3.24.0 announcement

Expected behavior

It would be great if you could add a modification to follow the value of the Flutter SDK.

cached_image_widget.dart

  CachedNetworkImage({
    super.key,
  ~~~
    this.filterQuality = FilterQuality.low,
  ~~~
  }) : _image = CachedNetworkImageProvider(

image.dart in the Flutter SDK

  Image.asset(
    String name, {
    super.key,
    AssetBundle? bundle,
    ~~~
    this.filterQuality = FilterQuality.medium,
    ~~~
  }) : image = ResizeImage.resizeIfNeeded(
         cacheWidth,
         cacheHeight,
         scale != null
           ? ExactAssetImage(name, bundle: bundle, scale: scale, package: package)
           : AssetImage(name, bundle: bundle, package: package),
       ),
       loadingBuilder = null,
       assert(cacheWidth == null || cacheWidth > 0),
       assert(cacheHeight == null || cacheHeight > 0);

Version: 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant