Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback #2

Open
valbaca opened this issue Oct 17, 2024 · 1 comment
Open

feedback #2

valbaca opened this issue Oct 17, 2024 · 1 comment

Comments

@valbaca
Copy link

valbaca commented Oct 17, 2024

Hi there! I've come here via Hacker News: https://news.ycombinator.com/item?id=41845397

https://www.rorvswild.com/blog/2024/rorvswild-rdoc-theme

Top-level feedback:

  • Overall, love it. So much crisper and the red brings it back to Ruby. Clear and elegant, exactly as Ruby should be!
  • Some confusing elements (but also less confusing than the original):
    • The yellow-highlight in the text vs the yellow-highlight on the right: the yellow highlight on the text seems to be for emphasis, while the highlight on the right seems to be a "you're looking at" indicator. They're both good but they're kind of clashing with their intent and their highlight nature draws one's eyes to them.

More opinionated:

  • scroll-to on link-clicks is too extra in my opinion. no motion is better. the scroll-to is a bit nauseating and slow.
  • Left index spacing padding is just a tad too much.
.nav-section > ul > li {
  padding: 0.25em 0.75rem;
}

could just be 0.25em;

@antoinem
Copy link
Member

Thanks a lot for the feedback, and for mentioning someone posted this on hn, I didn't know!

I just removed the yellow background used for text emphasis.
Not sure about the other suggestions yet… I'll ask around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants