Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Faceit calls to the shared library #32

Open
todo bot opened this issue Jul 25, 2020 · 1 comment
Open

Move Faceit calls to the shared library #32

todo bot opened this issue Jul 25, 2020 · 1 comment

Comments

@todo
Copy link

todo bot commented Jul 25, 2020

// TODO create interfaces for response data from Faceit API (Perhaps these API calls belong in @bantr/lib ...)
/**
* Service for Faceit


This issue was generated by todo based on a TODO comment in eff8d5d when #31 was merged. cc @Bantr.
@todo todo bot added the todo 🗒️ label Jul 25, 2020
@niekcandaele niekcandaele changed the title create interfaces for response data from Faceit API (Perhaps these API calls bel... Move Faceit calls to the shared library Jul 25, 2020
@niekcandaele
Copy link
Member

For more code reusability, we should move all Faceit API calls to the shared lib repo.

First we should add these functions to the Lib before this issue can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant