Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error activating extension while trying to read json file with comments #640

Open
ronil195 opened this issue Jan 8, 2025 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@ronil195
Copy link

ronil195 commented Jan 8, 2025

Describe the bug
The error below happens when I activate the extension:

2025-01-08 16:31:53.270 [info] ExtensionService#_doActivateExtension BalticAmadeus.pro-bro, startup: false, activationEvent: 'onView:pro-bro-databases'
2025-01-08 16:31:53.424 [error] Activating extension BalticAmadeus.pro-bro failed due to an error:
2025-01-08 16:31:53.424 [error] SyntaxError: Expected double-quoted property name in JSON at position 36 (line 2 column 34)
at JSON.parse ()
at wt (c:\Users\ronil.vscode\extensions\balticamadeus.pro-bro-1.8.0\out\extension.js:94:839)
at y (c:\Users\ronil.vscode\extensions\balticamadeus.pro-bro-1.8.0\out\extension.js:110:1975)
at c:\Users\ronil.vscode\extensions\balticamadeus.pro-bro-1.8.0\out\extension.js:110:1845
at Qt (c:\Users\ronil.vscode\extensions\balticamadeus.pro-bro-1.8.0\out\extension.js:110:1773)
at K0.n (file:///c:/Program%20Files/Microsoft%20VS%20Code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:115:4447)
at K0.m (file:///c:/Program%20Files/Microsoft%20VS%20Code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:115:4410)
at K0.l (file:///c:/Program%20Files/Microsoft%20VS%20Code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:115:3866)

I'm running vscode version 1.96.2 on Windows 11, version 24h2
ProBro Version: 1.8.0

My openedge-project.json:
{
"name": "Unificacao de bases", // Project name, will be used in the future for dependency management
"version": "1.0", // Project version number, will be used in the future for dependency management
"oeversion": "12.2", // Must reference an existing ABL version in Settings -> Extensions -> ABL Configuration -> Runtimes
"graphicalMode": false, // True for prowin[32], false for _progres
"charset": "iso8859-1",
"extraParameters": "-basekey INI -ininame C:/Totvs/datasul/vscode/scripts/datasul.ini -pf C:/Totvs/datasul/vscode/scripts/datasul.pf", // Extra Progress command line parameters
"preprocessor": { // Customize parser behavior (optional)
// "windowSystem": "MS-WINDOWS",
// "processArchitecture": 32
},
// Only required if your project use extensions other than ".i" for include files.
// If not specified, modifying files with such extension will not trigger a compilation
"includeFileExtensions": [ ".i", ".f" ],
"buildPath": [
// Entries can have type 'source' or 'propath'. Path attribute is mandatory. Build attribute is optional (defaults to 'path'). Xref attribute is optional (defaults to 'build/.pct' or '.builder/srcX')
{ "type": "source", "path": "newell/unificacao"},
{ "type": "source", "path": "newell/unificacao/aftersales"},
{ "type": "source", "path": "newell/espJCS"},
{ "type": "source", "path": "newell/espNBB"},
{ "type": "source", "path": "C:/Totvs/datasul/vscode/apoio/foundation"},
{ "type": "source", "path": "C:/Totvs/datasul/vscode/apoio/ems2"},
{ "type": "source", "path": "C:/Totvs/datasul/vscode/apoio/ems5"},
{ "type": "source", "path": "C:/Totvs/datasul/vscode/apoio/ddk"},
{ "type": "propath", "path": "C:/Progress/OpenEdge/tty/netlib/OpenEdge.net.pl"}
],
"dbConnections": [ // Unlimited number of connections - Beware of -h
{
"name": "ems2cad", // Logical name of database, or physical name if -ld is not used
"connect": "-db ems2cad -H srvtotvs12 -S 23611 -U sysprogress -P aaa-ld mgcad", // ABL connection string
"schemaFile": "dump/ems2cad.df",
"aliases": []
},
{
"name": "ems2mov", // Logical name of database, or physical name if -ld is not used
"connect": "-db ems2mov -H srvtotvs12 -S 23601 -U sysprogress -P aaa-ld mgmov", // ABL connection string
"schemaFile": "dump/ems2mov.df",
"aliases": []
},
{
"name": "ems5cad", // Logical name of database, or physical name if -ld is not used
"connect": "-db ems5cad -H srvtotvs12 -S 23605 -U sysprogress -P aaa-ld emscad", // ABL connection string
"schemaFile": "dump/ems5cad.df",
"aliases": []
},
{
"name": "ems5mov", // Logical name of database, or physical name if -ld is not used
"connect": "-db ems5mov -H srvtotvs12 -S 23606 -U sysprogress -P aaa-ld emsmov", // ABL connection string
"schemaFile": "dump/ems5mov.df",
"aliases": []
},
{
"name": "emsfnd", // Logical name of database, or physical name if -ld is not used
"connect": "-db emsfnd -H srvtotvs12 -S 23619 -U sysprogress -P aaa-ld emsfnd", // ABL connection string
"schemaFile": "dump/emsfnd.df",
"aliases": []
},
{
"name": "hcm", // Logical name of database, or physical name if -ld is not used
"connect": "-db hcm -H srvtotvs12 -S 23607 -U sysprogress -P aaa-ld hcm", // ABL connection string
"schemaFile": "dump/hcm.df",
"aliases": []
},
{
"name": "ems2esp-jcs", // Logical name of database, or physical name if -ld is not used
"connect": "-db ems2esp-jcs -H srvtotvs12 -S 50049 -ld emsesp", // ABL connection string
"schemaFile": "dump/ems2esp-jcs.df", //dump/ems2esplilo.df
"aliases": []
}

],
"numThreads": 1, // Number of OpenEdge sessions handling build
"procedures": [
  // List of procedures executed before the main entry point
  // Init mode -> before setting propath and DB connections
  // Once, persistent and super -> after setting propath and DB connections
  //{ "name": "scripts/login.p", "mode": "once" /* Mode can be init, once, persistent or super */ }
  {"name": "C:/Totvs/datasul/vscode/scripts/datasul-desenv.p", "mode": "persistent"}

],
"profiles": [ /* See section below */ ]

}

@PauliusKu
Copy link
Collaborator

Hi, it seems to be the same issue as here #623
For now you could just install previous version 1.7.0
I plan to fix this today or tomorrow with new release.

@PauliusKu PauliusKu added the bug Something isn't working label Jan 9, 2025
@PauliusKu PauliusKu self-assigned this Jan 9, 2025
@PauliusKu PauliusKu added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Jan 9, 2025
@PauliusKu
Copy link
Collaborator

I see now that your issue is a bit different, than I expected.

You are using slash symbol comments in your openedge-project.json file, which does not work with JSON parser we use (as pure JSON standard doses not support comments).
So it should work fine if you remove comments
I will keep this ticket open and will look into it if we can fix in a future release.

@ronil195

@PauliusKu PauliusKu changed the title Error activating extension Error activating extension while trying to read json file with comments Jan 10, 2025
@ronil195
Copy link
Author

Hi, you're right.

I removed the slash comments and its worked.

@PauliusKu PauliusKu reopened this Jan 13, 2025
@PauliusKu PauliusKu assigned SeNaSa231 and unassigned PauliusKu Jan 14, 2025
@PauliusKu PauliusKu added this to the Future release milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants