Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[balls] A simple int arg for health and attack bonus in /count and /admin count #461

Open
imtherealF1 opened this issue Nov 12, 2024 · 4 comments

Comments

@imtherealF1
Copy link
Contributor

Describe the feature you'd like
You would be able to type a number you want for the attack bonus or health bonus, and it would count the balls you have with that bonus only.

Additional context
It would need checks to prevent numbers more than the settings.max_attack and settings.max_health.

@imtherealF1
Copy link
Contributor Author

Thinking about it again, I don't think the arguments will be necessary for /admin count. I already made the code for /balls count ready. and I want to hear opinions on whether I should also make it for /admin count or not.

@flaree
Copy link
Member

flaree commented Nov 25, 2024

Personally i'm not a fan, I just think its more clutter for the arguments

@imtherealF1
Copy link
Contributor Author

I think that /count should have some sorting options, and it only has 3 which isn't cluttered at all, and with the shinies being moved to special soon it will become 2, so I think that it wouldn't be a big issue.

@laggron42
Copy link
Member

I agree with flare where we should avoid too much cluttering, but at the same time advanced filtering is useful. I've been considering a pseudo language for advanced filtering like this, may want to wait for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants