-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dependency on std::vector #40
Comments
@TeachRaccooon can you give a status update on where we are with this? |
I'll soon be opening a new PR which changes CQRRPT to be fully pointer-based. |
@TeachRaccooon can I get another update on this? |
I haven't deliberately gotten back to the existing code to resolve this. |
Good stuff. Just wanted to know where we stand. |
@PTNobel and @burlen have reported that using
std::vector<T>
instead of plain buffersT*
makes it harder to adapt RandLAPACK code for GPUs. We should identify the places wherestd::vector<T>
is actually necessary and where it can be replaced byT*
. In general, if we have a std::vectorvec
and a code path does not callRandLAPACK::util::upsize(new_size, vec)
, then we can probably replacevec
with a buffer.Fixing this isn't urgent, but the sooner we do it, the easier it will be.
The text was updated successfully, but these errors were encountered: