Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Launching with Celluloid launches both mpv and celluloid #21

Open
2 tasks done
yigib opened this issue Jun 13, 2023 · 1 comment
Open
2 tasks done

bug: Launching with Celluloid launches both mpv and celluloid #21

yigib opened this issue Jun 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@yigib
Copy link

yigib commented Jun 13, 2023

Bug Description

Choosing Celluloid as the player and clicking the icon results in both mpv and Celluloid launching, both playing the video.

How to Reproduce

Steps to reproduce the behavior:

  1. Go to settings and choose Celluloid
  2. Open any youtube video
  3. Click on the extension icon
  4. See both players launching

Expected Behavior

Only celluloid should be launching.

Version

nightly (master branch)

Configuration

players:
  mpv:
    name: mpv
    executable: mpv
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: ""
    new_window: ""
    needs_ipc: true
    flag_overrides: {}
  celluloid:
    name: Celluloid
    executable: celluloid
    fullscreen: ""
    pip: ""
    enqueue: "--enqueue"
    new_window: "--new-window"
    needs_ipc: false
    flag_overrides: 
      "*": "--mpv-%s"
  mpvnet:
    name: mpv.net
    executable: mpvnet.exe
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: "--queue"
    new_window: ""
    needs_ipc: false
    flag_overrides: {}

Relevant log output (optional)

No response

What browsers are you seeing the problem on? (optional)

No response

Checklist:

  • I have checked for existing issues that describe my problem prior to opening this one.
  • I understand that improperly formatted bug reports may be closed without explanation.
@yigib yigib added the bug Something isn't working label Jun 13, 2023
@Baldomo Baldomo self-assigned this Jun 29, 2023
@Baldomo
Copy link
Owner

Baldomo commented Aug 26, 2024

After some testing, I could not reproduce this bug. Does it still happen on newer versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants