Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code Generation fails depending on locale #83

Open
bardiir opened this issue May 21, 2021 · 3 comments
Open

QR code Generation fails depending on locale #83

bardiir opened this issue May 21, 2021 · 3 comments
Labels

Comments

@bardiir
Copy link

bardiir commented May 21, 2021

The QR code generation does fail, depending on the locale if the decimal separator is not defined as a point.

This is caused by the library generating comma separated numbers in places where a point value is expected, for example <g transform="scale(10,811)"> instead of <g transform="scale(10.811)"> on de_DE as the float is transformed with a comma as a decimal separator by the sprintf including it as a string, basically casting float to string in the process.

Imagick png is also affected by the locale, although I haven't figured out exactly why yet.

@DASPRiD
Copy link
Member

DASPRiD commented May 21, 2021

PR #68 tried to address this issue, but the author never followed up on the required changes. Feel free to create a new PR for that.

@bardiir
Copy link
Author

bardiir commented May 24, 2021

#84

@dictacode
Copy link

I have the same problem, my app works fine until i change the locale settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants