-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eye rotation doesn't work with inherited colors #106
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
============================================
+ Coverage 63.42% 65.49% +2.07%
- Complexity 928 939 +11
============================================
Files 47 48 +1
Lines 2783 2855 +72
============================================
+ Hits 1765 1870 +105
+ Misses 1018 985 -33
Continue to review full report at Codecov.
|
If you want a test is it okay to add my non-symmetrical eye interface to the codebase? |
No idea why the test is failing, is there anyway to see the file generated by the CI? |
Okay, figured it out. The code was fine and the files were identical to the human eye. Just slight differences probably due to imagick version differences between my system and the test platform. So I extracted the files from a workflow artifact and now the tests pass. |
An alternative would be to test with the SVG renderer, since that output is predictable. |
Yup, definitely a safer option, but perhaps better as a follow-up to update all the integration tests. |
@DASPRiD Any feedback, or things you'd like addressed? |
Generally this looks good to me. I'm not sure about the |
How about you rename it to |
@mustanggb I haven't heard back from you ever. I'm currently preparing a new major release. If I don't hear back from you in the next few days, I'm going to close this PR. |
Heard back about what? I was just waiting for it to be merged. |
@mustanggb See my comments from March 14 and 27, 2022 :) |
Also, please rebase against the new main branch. |
Just a rename then, I don't mind it. Rename and rebase at #174. |
Fixes #105.