Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Handling signing of other targets (extensions) #250

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

GMinucci
Copy link
Collaborator

@GMinucci GMinucci commented Jan 27, 2025

What does this PR do

Allows adding target extensions to the variants.yml file so it can be included in the app_identifiers on Match for signing

How can it be tested

After creating an App Extension on Xcode, include it in the variants.yml file with the necessary information. Once you run the variants switch command you should see the extension information included in the Matchfile for fastlane and the respective signing options in Xcode.

Task

resolves #169

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

Sorry, something went wrong.

@GMinucci GMinucci marked this pull request as draft January 27, 2025 11:11
@GMinucci GMinucci changed the title [draft] Feat: Handling signing of other targets (extensions) Feat: Handling signing of other targets (extensions) Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Warnings
⚠️ Pull request is relatively big. If this PR contains multiple changes, consider splitting it into separate PRs for easier reviews.

Generated by 🚫 Danger Swift against 7a9b473

@GMinucci GMinucci marked this pull request as ready for review January 27, 2025 12:59
@GMinucci GMinucci merged commit 559a21f into develop Jan 27, 2025
11 checks passed
@GMinucci GMinucci deleted the feat/169-signing-extensions branch January 27, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple Bundle ID and/or per target Bundle ID
2 participants