You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.
There appears to be redundant adding of channels. The initialize function adds channels when passed to the first parameter (line 25), but a few lines below the channels are added again using a loop (lines 27-28).
Personally I think it would be better to let the instrument controller module add the channels internally, and simply send a list of integers denoting which channels to enable. That would make future movement to a generic module easier. What do you think?
The text was updated successfully, but these errors were encountered:
There appears to be redundant adding of channels. The initialize function adds channels when passed to the first parameter (line 25), but a few lines below the channels are added again using a loop (lines 27-28).
DAQ-and-laser-API/NIDAQ/NIDAQSweepMeasurement.py
Lines 24 to 28 in ac97760
Personally I think it would be better to let the instrument controller module add the channels internally, and simply send a list of integers denoting which channels to enable. That would make future movement to a generic module easier. What do you think?
The text was updated successfully, but these errors were encountered: