Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Profile IMGs #86

Open
4 tasks
vitorvicente opened this issue Sep 21, 2020 · 1 comment
Open
4 tasks

Refactor Profile IMGs #86

vitorvicente opened this issue Sep 21, 2020 · 1 comment
Labels
Enhancement New feature or request

Comments

@vitorvicente
Copy link
Member

Refractor the profileIMG system to store the direct link to the image.

Rename /profiles to /memberData, then have a subfolder for each member with their UID has the key, and inside keep any files related to them.

This will required:

  • Firebase storage changes
  • Adding/Editing/Removing member changes in the EBoard panel
  • Changes to personal panel
  • Changes to inquisitor dataForm for new acceptees
@vitorvicente vitorvicente added the Enhancement New feature or request label Sep 21, 2020
@ROODAY ROODAY changed the title Refractor Profile IMGs Refactor Profile IMGs Sep 22, 2020
@ROODAY
Copy link
Member

ROODAY commented Sep 22, 2020

Also as part of this can we make the profile images consistently sized, right now they have width: 75% which makes sure they resize on different screens, but this makes it hard to ensure consistency (some are oval, some are circles, etc). An easy fix is to apply this to images:

width: 250px;
height: 250px;
object-fit: cover;

250px looks good on phones and desktop, but if you really want to keep the 75% width you'll need to write JS logic to resize the height to match width (feels unnecessary but up to you). You'll need object-fit regardless as that makes sure the images are centered and cropped regardless of dimensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants