Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use liblbfgs instead? #72

Open
nileshpatra opened this issue Jul 12, 2021 · 2 comments
Open

Possible to use liblbfgs instead? #72

nileshpatra opened this issue Jul 12, 2021 · 2 comments

Comments

@nileshpatra
Copy link

Hi,

Thanks for your work on bustools.

Bit of context:
When I was updating the corresponding bustools in Debian to latest upstream, I noticed that there are new dependencies being vendored in "dependencies/" dir.

Since shipping code copies isn't the best for us as a distribution, I patched the build system to use packaged libraries instead. eigen3 was already packages, I packaged cppnumericalsolvers and uploaded -- all good till now.

Now, the library "LBFGSpp" looks like it is a fork of liblbfgs. Now, liblbfgs is a package in the distribution already, and packaging a fork is more or less always suboptimal.

Now:
Hence, would it be possible for you to somehow patch stuff to use the original lib instead of fork?

I also opened an issue on LBFGSpp repository to see the possibility of they merging their code in liblbfgs. But since they have diverged quite a bit, this looks a little hard to get going.
Hence, is there a possibility for you to use the original one instead of the fork?

@nileshpatra
Copy link
Author

CC: @pmelsted @johan-gson

@johan-gson
Copy link
Contributor

Hi,

Thank you for the suggestion. We however have no plans to change this. For us it is important that building bustools is robust and always works - this is why the dependencies are added to the repository, and that we hence can trust that the code works regardless of any changes made to the original repositories. Sorry for any inconvenience this may cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants