Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align components new when position other components between them #16

Open
JaquelineP opened this issue Jan 7, 2014 · 6 comments
Open
Labels

Comments

@JaquelineP
Copy link

If you position a component over another one, align the new component below the other component. Then you have to align the other compontents (below new component), too.

@daniel-wer
Copy link
Contributor

I've just finished implementing this, components can now be inserted in the middle of the "data flow" and all following components will be repositioned. Additionally, once a component is dragged out of the "data flow" the gap will be closed and all components below will be moved up.
All this happens without the DataFlowAlignment components from Jens. Once I finished cleaning this up and the remaining leftovers used to work with these DataFlowAlignment components are removed, this issue can be closed.

@Lixissimus
Copy link

Nice one! I feel like it would be awesome, if you re-align the components at the moment, where the preview morph snaps below a component or leaves this position. Then you have a better preview what will happen when you drop the morph. The preview morph will always create enough space for the component to fit in there, since it uses the same algorithm, so you don't have to re-align when you actually drop the morph.

@daniel-wer
Copy link
Contributor

Yes this sounds nice, I'll change that in a minute.

@JaquelineP
Copy link
Author

Nice!
I would be awesome, too, if you re-align components also if they resize. At the moment nothing happens if you minimize a compoment (by changing their size), the other components don't align.

@daniel-wer
Copy link
Contributor

Both suggestions are now implemented as well, feels very good.

@daniel-wer
Copy link
Contributor

Wow this developed into serious coding nightmare. I've nearly worked all day on this, several rewrites from scratch later (because it got too complicated) there now is a nicely working version :)

  • components can be moved between other components
  • components can be taken out of the dataflow => the produced gap will be closed
  • components can be freely moved around in the dataflow (there is some flickering if you hit the top most component, we'll have to live with that for the moment)
  • fans will also be moved and move all "dependent" components, so the dataflow won't be destroyed or changed

Only thing left is to be able to move fan-components, I'll implement that later as there are some additional missing parts for that, that weren't implemented when we rewrote the fan components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants