+
+
+ 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Project Dependencies
compile
+The following is a list of compile dependencies for this project. These dependencies are required to compile and run the application:
+| GroupId | +ArtifactId | +Version | +Type | +Licenses |
|---|---|---|---|---|
| javax.xml.bind | +jaxb-api | +2.3.0 | +jar | +CDDL 1.1GPL2 w/ CPE |
| joda-time | +joda-time | +2.9.2 | +jar | +Apache 2 |
| org.apache.commons | +commons-imaging | +1.0-alpha2 | +jar | +Apache License, Version 2.0 |
test
+The following is a list of test dependencies for this project. These dependencies are only required to compile and run unit tests for the application:
+| GroupId | +ArtifactId | +Version | +Type | +Licenses |
|---|---|---|---|---|
| junit | +junit | +4.12 | +jar | +Eclipse Public License 1.0 |
Project Transitive Dependencies
+The following is a list of transitive dependencies for this project. Transitive dependencies are the dependencies of the project dependencies.
test
+The following is a list of test dependencies for this project. These dependencies are only required to compile and run unit tests for the application:
+| GroupId | +ArtifactId | +Version | +Type | +Licenses |
|---|---|---|---|---|
| org.hamcrest | +hamcrest-core | +1.3 | +jar | +New BSD License |
Project Dependency Graph
Dependency Tree
+-
+
- org.springframework:gs-maven:jar:0.1.0
![[Information]](./images/icon_info_sml.gif)
+-
+
- joda-time:joda-time:jar:2.9.2 (compile)
+
- junit:junit:jar:4.12 (test)
+
-
+
- org.hamcrest:hamcrest-core:jar:1.3 (test)
+ - org.hamcrest:hamcrest-core:jar:1.3 (test)
- org.apache.commons:commons-imaging:jar:1.0-alpha2 (compile)
+
- javax.xml.bind:jaxb-api:jar:2.3.0 (compile)
- joda-time:joda-time:jar:2.9.2 (compile)
Licenses
+Apache 2: Joda-Time
+CDDL 1.1: jaxb-api
+Unknown: gs-maven
+Eclipse Public License 1.0: JUnit
+Apache License, Version 2.0: Apache Commons Imaging
+GPL2 w/ CPE: jaxb-api
+New BSD License: Hamcrest Core
Dependency File Details
+| Filename | +Size | +Entries | +Classes | +Packages | +Java Version | +Debug Information |
|---|---|---|---|---|---|---|
| jaxb-api-2.3.0.jar | +125.6 kB | +136 | +111 | +7 | +9 | +Yes |
| joda-time-2.9.2.jar | +625.6 kB | +752 | +246 | +7 | +1.5 | +Yes |
| junit-4.12.jar | +314.9 kB | +323 | +286 | +30 | +1.5 | +Yes |
| commons-imaging-1.0-alpha2.jar | +770.3 kB | +486 | +431 | +41 | +1.8 | +Yes |
| hamcrest-core-1.3.jar | +45 kB | +52 | +45 | +3 | +1.5 | +Yes |
| Total | +Size | +Entries | +Classes | +Packages | +Java Version | +Debug Information |
| 5 | +1.9 MB | +1749 | +1119 | +88 | +9 | +5 |
| compile: 3 | +compile: 1.5 MB | +compile: 1374 | +compile: 788 | +compile: 55 | +9 | +compile: 3 |
| test: 2 | +test: 360 kB | +test: 375 | +test: 331 | +test: 33 | +1.5 | +test: 2 |
+
+
+
+
+
diff --git a/target/site/dependency-info.html b/target/site/dependency-info.html
new file mode 100644
index 0000000..c9f5c15
--- /dev/null
+++ b/target/site/dependency-info.html
@@ -0,0 +1,99 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Dependency Information
Apache Maven
+
+
<dependency> + <groupId>org.springframework</groupId> + <artifactId>gs-maven</artifactId> + <version>0.1.0</version> +</dependency>
Apache Ivy
+
+
<dependency org="org.springframework" name="gs-maven" rev="0.1.0"> + <artifact name="gs-maven" type="jar" /> +</dependency>
Groovy Grape
+
+
@Grapes( +@Grab(group='org.springframework', module='gs-maven', version='0.1.0') +)
Gradle/Grails
+
+
implementation 'org.springframework:gs-maven:0.1.0'
Scala SBT
+
+
libraryDependencies += "org.springframework" % "gs-maven" % "0.1.0"
Leiningen
+
+
[org.springframework/gs-maven "0.1.0"]
+
+
+
+
+
diff --git a/target/site/images/close.gif b/target/site/images/close.gif
new file mode 100644
index 0000000..1c26bbc
Binary files /dev/null and b/target/site/images/close.gif differ
diff --git a/target/site/images/collapsed.gif b/target/site/images/collapsed.gif
new file mode 100644
index 0000000..6e71084
Binary files /dev/null and b/target/site/images/collapsed.gif differ
diff --git a/target/site/images/expanded.gif b/target/site/images/expanded.gif
new file mode 100644
index 0000000..0fef3d8
Binary files /dev/null and b/target/site/images/expanded.gif differ
diff --git a/target/site/images/external.png b/target/site/images/external.png
new file mode 100644
index 0000000..3f999fc
Binary files /dev/null and b/target/site/images/external.png differ
diff --git a/target/site/images/icon_error_sml.gif b/target/site/images/icon_error_sml.gif
new file mode 100644
index 0000000..61132ef
Binary files /dev/null and b/target/site/images/icon_error_sml.gif differ
diff --git a/target/site/images/icon_info_sml.gif b/target/site/images/icon_info_sml.gif
new file mode 100644
index 0000000..c6cb9ad
Binary files /dev/null and b/target/site/images/icon_info_sml.gif differ
diff --git a/target/site/images/icon_success_sml.gif b/target/site/images/icon_success_sml.gif
new file mode 100644
index 0000000..52e85a4
Binary files /dev/null and b/target/site/images/icon_success_sml.gif differ
diff --git a/target/site/images/icon_warning_sml.gif b/target/site/images/icon_warning_sml.gif
new file mode 100644
index 0000000..873bbb5
Binary files /dev/null and b/target/site/images/icon_warning_sml.gif differ
diff --git a/target/site/images/logos/build-by-maven-black.png b/target/site/images/logos/build-by-maven-black.png
new file mode 100644
index 0000000..919fd0f
Binary files /dev/null and b/target/site/images/logos/build-by-maven-black.png differ
diff --git a/target/site/images/logos/build-by-maven-white.png b/target/site/images/logos/build-by-maven-white.png
new file mode 100644
index 0000000..7d44c9c
Binary files /dev/null and b/target/site/images/logos/build-by-maven-white.png differ
diff --git a/target/site/images/logos/maven-feather.png b/target/site/images/logos/maven-feather.png
new file mode 100644
index 0000000..b5ada83
Binary files /dev/null and b/target/site/images/logos/maven-feather.png differ
diff --git a/target/site/images/newwindow.png b/target/site/images/newwindow.png
new file mode 100644
index 0000000..6287f72
Binary files /dev/null and b/target/site/images/newwindow.png differ
diff --git a/target/site/index.html b/target/site/index.html
new file mode 100644
index 0000000..b3d31f4
--- /dev/null
+++ b/target/site/index.html
@@ -0,0 +1,74 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
diff --git a/target/site/plugin-management.html b/target/site/plugin-management.html
new file mode 100644
index 0000000..cd96198
--- /dev/null
+++ b/target/site/plugin-management.html
@@ -0,0 +1,94 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+ Project Plugin Management
+| GroupId | +ArtifactId | +Version |
|---|---|---|
| org.apache.maven.plugins | +maven-antrun-plugin | +3.1.0 |
| org.apache.maven.plugins | +maven-assembly-plugin | +3.6.0 |
| org.apache.maven.plugins | +maven-dependency-plugin | +3.6.1 |
| org.apache.maven.plugins | +maven-release-plugin | +3.0.1 |
+
+
+
+
+
diff --git a/target/site/plugins.html b/target/site/plugins.html
new file mode 100644
index 0000000..241264a
--- /dev/null
+++ b/target/site/plugins.html
@@ -0,0 +1,128 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+ Project Build Plugins
+| GroupId | +ArtifactId | +Version |
|---|---|---|
| org.apache.maven.plugins | +maven-clean-plugin | +3.2.0 |
| org.apache.maven.plugins | +maven-compiler-plugin | +3.11.0 |
| org.apache.maven.plugins | +maven-deploy-plugin | +3.1.1 |
| org.apache.maven.plugins | +maven-install-plugin | +3.1.1 |
| org.apache.maven.plugins | +maven-jar-plugin | +3.3.0 |
| org.apache.maven.plugins | +maven-resources-plugin | +3.3.1 |
| org.apache.maven.plugins | +maven-shade-plugin | +3.2.4 |
| org.apache.maven.plugins | +maven-site-plugin | +3.12.1 |
| org.apache.maven.plugins | +maven-surefire-plugin | +3.2.2 |
Project Report Plugins
+| GroupId | +ArtifactId | +Version |
|---|---|---|
| com.github.spotbugs | +spotbugs-maven-plugin | +4.8.5.0 |
| org.apache.maven.plugins | +maven-project-info-reports-plugin | +3.5.0 |
+
+
+
+
+
diff --git a/target/site/project-info.html b/target/site/project-info.html
new file mode 100644
index 0000000..755c4e8
--- /dev/null
+++ b/target/site/project-info.html
@@ -0,0 +1,97 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+ Project Information
+This document provides an overview of the various documents and links that are part of this project's general information. All of this content is automatically generated by Maven on behalf of the project.
Overview
+| Document | +Description |
|---|---|
| Dependencies | +This document lists the project's dependencies and provides information on each dependency. |
| Dependency Information | +This document describes how to include this project as a dependency using various dependency management tools. |
| About | +There is currently no description associated with this project. |
| Plugin Management | +This document lists the plugins that are defined through pluginManagement. |
| Plugins | +This document lists the build plugins and the report plugins used by this project. |
| Summary | +This document lists other related information of this project |
+
+
+
+
+
diff --git a/target/site/project-reports.html b/target/site/project-reports.html
new file mode 100644
index 0000000..d7cb277
--- /dev/null
+++ b/target/site/project-reports.html
@@ -0,0 +1,77 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
diff --git a/target/site/spotbugs.html b/target/site/spotbugs.html
new file mode 100644
index 0000000..5375b72
--- /dev/null
+++ b/target/site/spotbugs.html
@@ -0,0 +1,844 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ SpotBugs Bug Detector Report
+The following document contains the results of SpotBugs
+SpotBugs Version is 4.8.5
+Threshold is medium
+Effort is default
Summary
+| Classes | +Bugs | +Errors | +Missing Classes |
|---|---|---|---|
| 42 | +81 | +0 | +0 |
Files
+| Class | +Bugs |
|---|---|
| program.main.Cactus | +1 |
| program.main.Controller | +15 |
| program.main.Field | +3 |
| program.main.Game | +9 |
| program.main.GamePanel | +1 |
| program.main.GameWindow | +2 |
| program.main.ImagePanel | +1 |
| program.main.InGame | +1 |
| program.main.NomadButtonPanel | +1 |
| program.main.NomadMoveWindow | +1 |
| program.main.NomadPipeInteraction | +1 |
| program.main.Pipe | +9 |
| program.main.Player | +10 |
| program.main.Plumber | +4 |
| program.main.PlumberButtonPanel | +1 |
| program.main.PlumberMoveWindow | +1 |
| program.main.PlumberPipeInteraction | +1 |
| program.main.Pump | +10 |
| program.main.Spring | +1 |
| program.main.restart_menu | +2 |
| program.main.settings | +1 |
| program.main.settings$1 | +1 |
| program.main.settings$2 | +1 |
| program.main.startMenu | +2 |
| program.main.startMenu$3 | +1 |
program.main.Cactus
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Random object created and used only once in new program.main.Cactus(String) | +BAD_PRACTICE | +DMI_RANDOM_USED_ONLY_ONCE | +24 | +High |
program.main.Controller
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Random object created and used only once in program.main.Controller.destroyPump() | +BAD_PRACTICE | +DMI_RANDOM_USED_ONLY_ONCE | +267 | +High |
| program.main.Controller.CurrentNomadTurn() may expose internal representation by returning Controller.CurrentNomad | +MALICIOUS_CODE | +EI_EXPOSE_REP | +120 | +Medium |
| program.main.Controller.CurrentPlumberTurn() may expose internal representation by returning Controller.CurrentPlumber | +MALICIOUS_CODE | +EI_EXPOSE_REP | +129 | +Medium |
| Public static program.main.Controller.getCurrentNomad() may expose internal representation by returning Controller.CurrentNomad | +MALICIOUS_CODE | +MS_EXPOSE_REP | +66 | +Medium |
| Public static program.main.Controller.getCurrentPlumber() may expose internal representation by returning Controller.CurrentPlumber | +MALICIOUS_CODE | +MS_EXPOSE_REP | +57 | +Medium |
| The method name program.main.Controller.CurrentNomadTurn() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +120 | +Medium |
| The method name program.main.Controller.CurrentPlumberTurn() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +129 | +Medium |
| Write to static field program.main.Controller.CurrentNomad from instance method program.main.Controller.turn() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +181 | +Medium |
| Write to static field program.main.Controller.CurrentPlumber from instance method program.main.Controller.turn() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +148 | +Medium |
| Write to static field program.main.Controller.CurrentTurnIsNomad from instance method program.main.Controller.turn() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +174 | +Medium |
| Write to static field program.main.Controller.GameOver from instance method program.main.Controller.turn() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +138 | +Medium |
| Unused field: program.main.Controller.nomadCoolDown | +PERFORMANCE | +UUF_UNUSED_FIELD | ++ | Medium |
| Unused field: program.main.Controller.plumberCoolDown | +PERFORMANCE | +UUF_UNUSED_FIELD | ++ | Medium |
program.main.Field
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| The method name program.main.Field.GetName() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +27 | +Medium |
| The method name program.main.Field.SetName(String) doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +21 | +Medium |
| The method name program.main.Field.SpareWater() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | ++ | Medium |
program.main.Game
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.Game.run() invokes System.exit(...), which shuts down the entire virtual machine | +BAD_PRACTICE | +DM_EXIT | +230 | +Medium |
| program.main.Game.Cactuses() may expose internal representation by returning Game.cactuses | +MALICIOUS_CODE | +EI_EXPOSE_REP | +133 | +Medium |
| program.main.Game.Fields() may expose internal representation by returning Game.fields | +MALICIOUS_CODE | +EI_EXPOSE_REP | +129 | +Medium |
| program.main.Game.Nomads() may expose internal representation by returning Game.nomads | +MALICIOUS_CODE | +EI_EXPOSE_REP | +109 | +Medium |
| program.main.Game.Pipes() may expose internal representation by returning Game.pipes | +MALICIOUS_CODE | +EI_EXPOSE_REP | +178 | +Medium |
| program.main.Game.Plumbers() may expose internal representation by returning Game.plumbers | +MALICIOUS_CODE | +EI_EXPOSE_REP | +119 | +Medium |
| program.main.Game.getGameWindow() may expose internal representation by returning Game.gameWindow | +MALICIOUS_CODE | +EI_EXPOSE_REP | +242 | +Medium |
| Primitive field program.main.Game.gamePanel is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. | +BAD_PRACTICE | +PA_PUBLIC_PRIMITIVE_ATTRIBUTE | +140 | +Medium |
| Primitive field program.main.Game.nomadButtonPanel is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. | +BAD_PRACTICE | +PA_PUBLIC_PRIMITIVE_ATTRIBUTE | +182 | +Medium |
| Primitive field program.main.Game.plumberButtonPanel is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. | +BAD_PRACTICE | +PA_PUBLIC_PRIMITIVE_ATTRIBUTE | +149 | +Medium |
| Unread field: program.main.Game.FPS_SET; should this field be static? | +PERFORMANCE | +SS_SHOULD_BE_STATIC | +35 | +Medium |
| Unread field: program.main.Game.UPS_SET; should this field be static? | +PERFORMANCE | +SS_SHOULD_BE_STATIC | +36 | +Medium |
program.main.GamePanel
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Write to static field program.main.GamePanel.game from instance method new program.main.GamePanel(Game) | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +25 | +High |
program.main.GameWindow
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.GameWindow.getNomadButtonPanel() may expose internal representation by returning GameWindow.nomadButtonPanel | +MALICIOUS_CODE | +EI_EXPOSE_REP | +15 | +Medium |
| program.main.GameWindow.getPlumberButtonPanel() may expose internal representation by returning GameWindow.plumberButtonPanel | +MALICIOUS_CODE | +EI_EXPOSE_REP | +19 | +Medium |
program.main.ImagePanel
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| new program.main.ImagePanel(BufferedImage) may expose internal representation by storing an externally mutable object into ImagePanel.image | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +18 | +Medium |
program.main.InGame
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Unread field: program.main.InGame.gameOver | +PERFORMANCE | +URF_UNREAD_FIELD | +13 | +Medium |
program.main.NomadButtonPanel
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Dead store to $L3 in program.main.NomadButtonPanel.actionPerformed(ActionEvent) | +STYLE | +DLS_DEAD_LOCAL_STORE | +91 | +High |
program.main.NomadMoveWindow
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Dead store to ppi in program.main.NomadMoveWindow.actionPerformed(ActionEvent) | +STYLE | +DLS_DEAD_LOCAL_STORE | +69 | +High |
program.main.NomadPipeInteraction
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Write to static field program.main.NomadPipeInteraction.endturn from instance method program.main.NomadPipeInteraction.actionPerformed(ActionEvent) | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +65 | +Medium |
program.main.Pipe
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Random object created and used only once in program.main.Pipe.canPlayerStep() | +BAD_PRACTICE | +DMI_RANDOM_USED_ONLY_ONCE | +488 | +High |
| Random object created and used only once in program.main.Pipe.repair() | +BAD_PRACTICE | +DMI_RANDOM_USED_ONLY_ONCE | +518 | +High |
| new program.main.Pipe(Pump, Plumber, String) may expose internal representation by storing an externally mutable object into Pipe.inPocketOf | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +67 | +Medium |
| program.main.Pipe.pickedUp(Plumber) may expose internal representation by storing an externally mutable object into Pipe.inPocketOf | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +202 | +Medium |
| The method name program.main.Pipe.GetSlippery() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +431 | +Medium |
| The method name program.main.Pipe.GetSticky() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +465 | +Medium |
| The method name program.main.Pipe.SetTurnNotToSlippery(int) doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +421 | +Medium |
| The method name program.main.Pipe.SpareWater() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +387 | +Medium |
program.main.Player
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.Player.getPicture() may expose internal representation by returning Player.file_pic | +MALICIOUS_CODE | +EI_EXPOSE_REP | +383 | +Medium |
| program.main.Player.getPosition() may expose internal representation by returning Player.currentPosition | +MALICIOUS_CODE | +EI_EXPOSE_REP | +175 | +Medium |
| program.main.Player.getPreviousPosition() may expose internal representation by returning Player.previousPosition | +MALICIOUS_CODE | +EI_EXPOSE_REP | +370 | +Medium |
| new program.main.Player(String, int, Pump, String) may expose internal representation by storing an externally mutable object into Player.currentPosition | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +35 | +Medium |
| new program.main.Player(String, int, Pump, String) may expose internal representation by storing an externally mutable object into Player.previousPosition | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +31 | +Medium |
| program.main.Player.setPosition(Pump) may expose internal representation by storing an externally mutable object into Player.currentPosition | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +184 | +Medium |
| Check for oddness that won't work for negative numbers in program.main.Player.render(Graphics) | +STYLE | +IM_BAD_CHECK_FOR_ODD | +57 | +Medium |
| program.main.Player.game should be package protected | +MALICIOUS_CODE | +MS_PKGPROTECT | ++ | Medium |
| The method name program.main.Player.GetName() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +73 | +Medium |
| The method name program.main.Player.SetName(String) doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +83 | +Medium |
program.main.Plumber
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.Plumber.getPipeInPocket() may expose internal representation by returning Plumber.pipeInPocket | +MALICIOUS_CODE | +EI_EXPOSE_REP | +202 | +Medium |
| program.main.Plumber.getPumpInPocket() may expose internal representation by returning Plumber.pumpInPocket | +MALICIOUS_CODE | +EI_EXPOSE_REP | +192 | +Medium |
| program.main.Plumber.setPipeInPocket(Pipe) may expose internal representation by storing an externally mutable object into Plumber.pipeInPocket | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +159 | +Medium |
| program.main.Plumber.setPumpInPocket(Pump) may expose internal representation by storing an externally mutable object into Plumber.pumpInPocket | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +169 | +Medium |
program.main.PlumberButtonPanel
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Dead store to $L3 in program.main.PlumberButtonPanel.actionPerformed(ActionEvent) | +STYLE | +DLS_DEAD_LOCAL_STORE | +133 | +Medium |
program.main.PlumberMoveWindow
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Dead store to ppi in program.main.PlumberMoveWindow.actionPerformed(ActionEvent) | +STYLE | +DLS_DEAD_LOCAL_STORE | +68 | +High |
program.main.PlumberPipeInteraction
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Write to static field program.main.PlumberPipeInteraction.endturn from instance method program.main.PlumberPipeInteraction.actionPerformed(ActionEvent) | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +73 | +Medium |
program.main.Pump
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Random object created and used only once in program.main.Pump.destroy() | +BAD_PRACTICE | +DMI_RANDOM_USED_ONLY_ONCE | +124 | +High |
| program.main.Pump.getConnectedPipes() may expose internal representation by returning Pump.connectedPipes | +MALICIOUS_CODE | +EI_EXPOSE_REP | +429 | +Medium |
| program.main.Pump.getPipeIn() may expose internal representation by returning Pump.in | +MALICIOUS_CODE | +EI_EXPOSE_REP | +224 | +Medium |
| program.main.Pump.getPipeOut() may expose internal representation by returning Pump.out | +MALICIOUS_CODE | +EI_EXPOSE_REP | +233 | +Medium |
| program.main.Pump.listNeighbours() may expose internal representation by returning Pump.neighbours | +MALICIOUS_CODE | +EI_EXPOSE_REP | +166 | +Medium |
| program.main.Pump.changePipeIn(Pipe) may expose internal representation by storing an externally mutable object into Pump.in | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +307 | +Medium |
| program.main.Pump.changePipeOut(Pipe) may expose internal representation by storing an externally mutable object into Pump.out | +MALICIOUS_CODE | +EI_EXPOSE_REP2 | +323 | +Medium |
| The method name program.main.Pump.SpareWater() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +378 | +Medium |
| Class program.main.Pump defines non-transient non-serializable instance field file_pic | +BAD_PRACTICE | +SE_BAD_FIELD | ++ | High |
program.main.Spring
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| The method name program.main.Spring.SpareWater() doesn't start with a lower case letter | +BAD_PRACTICE | +NM_METHOD_NAMING_CONVENTION | +79 | +Medium |
program.main.restart_menu
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Write to static field program.main.restart_menu.quit_boolean from instance method new program.main.restart_menu() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +57 | +Medium |
| Write to static field program.main.restart_menu.restart_boolean from instance method new program.main.restart_menu() | +STYLE | +ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | +58 | +Medium |
program.main.settings
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| The class name program.main.settings doesn't start with an upper case letter | +BAD_PRACTICE | +NM_CLASS_NAMING_CONVENTION | +18 | +Medium |
program.main.settings$1
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.settings$1.actionPerformed(ActionEvent) might ignore java.lang.Exception | +BAD_PRACTICE | +DE_MIGHT_IGNORE | +111 | +Medium |
program.main.settings$2
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| program.main.settings$2.actionPerformed(ActionEvent) might ignore java.lang.Exception | +BAD_PRACTICE | +DE_MIGHT_IGNORE | +186 | +Medium |
program.main.startMenu
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Found reliance on default encoding in program.main.startMenu.StoryBoard(): new java.util.Scanner(File) | +I18N | +DM_DEFAULT_ENCODING | +160 | +High |
| The class name program.main.startMenu doesn't start with an upper case letter | +BAD_PRACTICE | +NM_CLASS_NAMING_CONVENTION | +14 | +Medium |
program.main.startMenu$3
+| Bug | +Category | +Details | +Line | +Priority |
|---|---|---|---|---|
| Dead store to settingswindow in program.main.startMenu$3.actionPerformed(ActionEvent) | +STYLE | +DLS_DEAD_LOCAL_STORE | +195 | +High |
+
+
+
+
+
diff --git a/target/site/summary.html b/target/site/summary.html
new file mode 100644
index 0000000..33b44c0
--- /dev/null
+++ b/target/site/summary.html
@@ -0,0 +1,109 @@
+
+
+
+
+
+
+
+ +
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Project Summary
Project Information
+| Field | +Value |
|---|---|
| Name | +gs-maven |
| Description | +- |
| Homepage | +- |
Project Organization
+This project does not belong to an organization.
Build Information
+| Field | +Value |
|---|---|
| GroupId | +org.springframework |
| ArtifactId | +gs-maven |
| Version | +0.1.0 |
| Type | +jar |
| Java Version | +1.8 |
+
+
+
+
+
diff --git a/target/spotbugsXml.xml b/target/spotbugsXml.xml
new file mode 100644
index 0000000..3bb9642
--- /dev/null
+++ b/target/spotbugsXml.xml
@@ -0,0 +1,159 @@
+
++
+
+ <p>
+ <a href="https://wiki.sei.cmu.edu/confluence/display/java/OBJ01-J.+Limit+accessibility+of+fields">SEI CERT rule OBJ01-J</a> requires that accessibility to fields must be limited.
+ Otherwise, the values of the fields may be manipulated from outside the class, which may be unexpected or
+ undesired behaviour.
+ In general, requiring that no fields are allowed to be public is overkill and unrealistic. Even
+ the rule mentions that final fields may be public. Besides final fields, there may be other
+ usages for public fields: some public fields may serve as "flags" that affect the behavior of
+ the class. Such flag fields are expected to be read by the current instance (or the current
+ class, in case of static fields), but written by others. If a field is both written by the
+ methods of the current instance (or the current class, in case of static fields) and from the
+ outside, the code is suspicious. Consider making these fields private and provide appropriate
+ setters, if necessary. Please note that constructors, initializers and finalizers are
+ exceptions, if only they write the field inside the class, the field is not considered as
+ written by the class itself.</p>
+
+
+
+<p>
+This instruction assigns a value to a local variable,
+but the value is not read or used in any subsequent instruction.
+Often, this indicates an error, because the value computed is never
+used.
+</p>
+<p>
+Note that Sun's javac compiler often generates dead stores for
+final local variables. Because SpotBugs is a bytecode-based tool,
+there is no easy way to eliminate these false positives.
+</p>
+
+
+
+ <p> This code stores a reference to an externally mutable object into the
+ internal representation of the object.
+ If instances
+ are accessed by untrusted code, and unchecked changes to
+ the mutable object would compromise security or other
+ important properties, you will need to do something different.
+ Storing a copy of the object is better approach in many situations.</p>
+
+
+
+ <p> Class names should be nouns, in mixed case with the first letter of each internal word capitalized. Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations (unless the abbreviation is much more widely used than the long form, such as URL or HTML).
+</p>
+
+
+
+ <p>
+This <code>public static</code> or <code>protected static</code> field is not final, and
+could be changed by malicious code or
+ by accident from another package.
+ The field could be made final to avoid
+ this vulnerability.</p>
+
+
+
+ <p>
+Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized.
+</p>
+
+
+
+ <p> This field is never read. Consider removing it from the class.</p>
+
+
+
+ <p> A public static method returns a reference to a mutable object or
+ an array that is part of the static state of the class.
+ Any code that calls this method can freely modify
+ the underlying array.
+ One fix is to return a copy of the array.</p>
+
+
+
+<p>
+The code uses x % 2 == 1 to check to see if a value is odd, but this won't work
+for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check
+for oddness, consider using (x & 1) == 1, or x % 2 != 0.
+</p>
+
+
+
+ <p> A mutable static field could be changed by malicious code or
+ by accident.
+ The field could be made package protected to avoid
+ this vulnerability.</p>
+
+
+
+ <p> This instance method writes to a static field. This is tricky to get
+correct if multiple instances are being manipulated,
+and generally bad practice.
+</p>
+
+
+
+<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
+the Random object. This produces mediocre quality random numbers and is inefficient.
+If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
+is required invoke a method on the existing Random object to obtain it.
+</p>
+
+<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
+number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
+(and avoid allocating a new SecureRandom for each random number needed).
+</p>
+
+
+
+ <p> Returning a reference to a mutable object value stored in one of the object's fields
+ exposes the internal representation of the object.
+ If instances
+ are accessed by untrusted code, and unchecked changes to
+ the mutable object would compromise security or other
+ important properties, you will need to do something different.
+ Returning a new copy of the object is better approach in many situations.</p>
+
+
+
+ <p> This field is never used. Consider removing it from the class.</p>
+
+
+
+ <p> This class contains an instance final field that
+ is initialized to a compile-time static value.
+ Consider making the field static.</p>
+
+
+
+<p> Found a call to a method which will perform a byte to String (or String to byte) conversion,
+and will assume that the default platform encoding is suitable. This will cause the application
+behavior to vary between platforms. Use an alternative API and specify a charset name or Charset
+object explicitly.</p>
+
+
+
+ <p> This method might ignore an exception. In general, exceptions
+ should be handled or reported in some way, or they should be thrown
+ out of the method.</p>
+
+
+
+ <p> Invoking System.exit shuts down the entire Java virtual machine. This
+ should only been done when it is appropriate. Such calls make it
+ hard or impossible for your code to be invoked by other code.
+ Consider throwing a RuntimeException instead.</p>
+
+
+
+<p> This Serializable class defines a non-primitive instance field which is neither transient,
+Serializable, or <code>java.lang.Object</code>, and does not appear to implement
+the <code>Externalizable</code> interface or the
+<code>readObject()</code> and <code>writeObject()</code> methods.
+Objects of this class will not be deserialized correctly if a non-Serializable
+object is stored in this field.</p>
+
+