Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up Extension #1

Open
BKDaugherty opened this issue Jul 21, 2021 · 0 comments
Open

Sign Up Extension #1

BKDaugherty opened this issue Jul 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@BKDaugherty
Copy link
Owner

Sign up really should take more than an email and a password. And the User object should store more than an email and password.

If you update the User Type here the Rust compiler should get mad at you in pretty much all of the places that you'll need to change.

So run cargo build a few times, and see what breaks and that will help you build the dependency graph of where the information has to be piped.

There are a few special places to check as well.

To avoid loading the hash of user passwords, we pass a PublicUser object around in a few places. The conversion from User -> PublicUser is defined here

Also, the psql storage isn't super safe, so rustc might not give you the hint on those.
You'll definitely need to update the defined models for working with User objects, as well as update the diesel migration for turning up the User table which generates the schema.rs file.

Check out this code for creating users in Psql from the CreateUserRequest object in types too

@BKDaugherty BKDaugherty added the enhancement New feature or request label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant