-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mincreshape changes dimension spacing from regular to irregular, when space has coordinates associated with it #56
Comments
This part has to be changed to something sane: |
What is the state of the zspace dimension variable in the original file? Does it contain a vector of spacings? |
yes, it does - see above. |
The code you cite is the way it is because I've had requests to preserve the vector of sample points along the dimension even when the overall spacing is regular. However, micreate_std_variable() automatically sets "irregular" spacing if the number of variable dimensions is > 0. I'd say it would be correct to override that in mincreshape by setting the spacing correctly after the step and start are set. |
It might be worth adding code to correctly fill out the contents of zspace , when mincreshape is extending FOV:
0 |
Test:
mincinfo -attvalue zspace:spacing PreventAD_424640_lego_phantom_MTL_20160621_greT2star_001.mnc
regular__
mincreshape -dimrange zspace=0,10 PreventAD_424640_lego_phantom_MTL_20160621_greT2star_001.mnc test.mnc
mincinfo -attvalue zspace:spacing test.mnc
irregular
mincinfo -varvalues zspace PreventAD_424640_lego_phantom_MTL_20160621_greT2star_001.mnc
-60.799999237061001622 .... 41.200000762938998378
The text was updated successfully, but these errors were encountered: