Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Island creation events (API) #2252

Open
Keisimm opened this issue Oct 7, 2024 · 1 comment
Open

Island creation events (API) #2252

Keisimm opened this issue Oct 7, 2024 · 1 comment
Assignees
@OmerBenGera
Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted

Comments

@Keisimm
Copy link

Keisimm commented Oct 7, 2024

Minecraft's Version

1.21.1

Plugin's Version

2024.3

Describe the bug

PreIslandCreateEvent doesn't provide the schematic name, but I need it there. After cancelling another event, IslandCreateEvent (which has the getSchematic() method), only the schematic pasting and database saving are cancelled, leaving the player with an empty island (which they can't be teleported to because it's "unsafe").

To Reproduce

Cancel IslandCreateEvent.

Additional Information

Please add the schematic name to PreIslandCreateEvent
@Keisimm Keisimm added the Pending Pending reports to be investigated label Oct 7, 2024
@OmerBenGera OmerBenGera added ✔️ Confirmed Confirmed bugs that can be replicated and removed Pending Pending reports to be investigated labels Oct 17, 2024
OmerBenGera added a commit that referenced this issue Oct 17, 2024
@OmerBenGera
Fixed cancelling of IslandCreateEvent is not handled correctly (#2252)
24aa557
@OmerBenGera OmerBenGera added the 🔧 Potential fix A potential fix was already submitted label Oct 17, 2024
@OmerBenGera
Copy link
Member

Check out latest dev build, let me know if it is fixed.
Cancelling the IslandCreateEvent should work now as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmerBenGera OmerBenGera

Labels
✔️ Confirmed Confirmed bugs that can be replicated 🔧 Potential fix A potential fix was already submitted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OmerBenGera @Keisimm